Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] cosize behaves inconsistently. #1178

Closed
eatingtomatoes opened this issue Nov 6, 2023 · 6 comments
Closed

[BUG] cosize behaves inconsistently. #1178

eatingtomatoes opened this issue Nov 6, 2023 · 6 comments
Labels
bug Something isn't working inactive-30d
Milestone

Comments

@eatingtomatoes
Copy link

eatingtomatoes commented Nov 6, 2023

Describe the bug

The behavior of cosize written in Python is inconsistent with that written in C++

C++

auto layout = make_layout(make_shape(_2 {}, _4 {}), make_stride(_2 {}, _4 {}));
print(cosize(layout)); // => _15

Python

>>> cosize(Layout((2, 4), (2, 4)))
16
@eatingtomatoes eatingtomatoes added ? - Needs Triage bug Something isn't working labels Nov 6, 2023
@eatingtomatoes eatingtomatoes reopened this Nov 6, 2023
@eatingtomatoes eatingtomatoes changed the title [BUG] coshape [BUG] cosize behaves inconsistenly. Nov 6, 2023
@eatingtomatoes eatingtomatoes changed the title [BUG] cosize behaves inconsistenly. [BUG] cosize behaves inconsistently. Nov 6, 2023
@thakkarV
Copy link
Collaborator

thakkarV commented Nov 6, 2023

@ccecka

@ccecka
Copy link

ccecka commented Nov 6, 2023

Thanks, this is a bug in pycute!

@eatingtomatoes
Copy link
Author

Should I close this issue now or wait for a fix?

@mnicely
Copy link
Collaborator

mnicely commented Nov 7, 2023

@eatingtomatoes I'll close once we have know the fix version

@mnicely mnicely added this to the CUTLASS 3.4 milestone Nov 7, 2023
Copy link

github-actions bot commented Dec 7, 2023

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@mnicely
Copy link
Collaborator

mnicely commented Jan 2, 2024

Resolved with v3.4 release

@mnicely mnicely closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working inactive-30d
Projects
None yet
Development

No branches or pull requests

4 participants