Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add a glibc symbol test as part of our per-PR tests #295

Closed
leofang opened this issue Dec 13, 2024 · 3 comments
Closed

CI: Add a glibc symbol test as part of our per-PR tests #295

leofang opened this issue Dec 13, 2024 · 3 comments
Labels
CI/CD CI/CD infrastructure P2 Low priority - Nice to have packaging Anything related to wheels or Conda packages test Addition or improved tests

Comments

@leofang
Copy link
Member

leofang commented Dec 13, 2024

xref: conda-forge/cudnn-feedstock#97

We already use auditwheel repair when building our wheels, so maybe this is redundant. Setting this to P2 for now.

@leofang leofang added CI/CD CI/CD infrastructure P2 Low priority - Nice to have packaging Anything related to wheels or Conda packages test Addition or improved tests labels Dec 13, 2024
@leofang
Copy link
Member Author

leofang commented Dec 13, 2024

@carterbox WDYT?

@carterbox
Copy link

I think it's good to either explicitly check glibc symbols or ensure that all of your build containers are using your oldest supported glibc and to know what that oldest supported version is.

It looks like auditwheel show is the one that does the glibc ABI checking.

@leofang
Copy link
Member Author

leofang commented Dec 13, 2024

or ensure that all of your build containers are using your oldest supported glibc and to know what that oldest supported version is.

Yeah we use cibuildwheel in the GHA to build wheels, and on Linux it does use the manylinux containers:
https://cibuildwheel.pypa.io/en/stable/options/#configuration-file
so my feeling is we don't have to do anything extra.

@leofang leofang closed this as not planned Won't fix, can't repro, duplicate, stale Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD infrastructure P2 Low priority - Nice to have packaging Anything related to wheels or Conda packages test Addition or improved tests
Projects
None yet
Development

No branches or pull requests

2 participants