Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT]: Add XXHash #290

Closed
sleeepyjack opened this issue Apr 5, 2023 · 1 comment · Fixed by #310
Closed

[ENHANCEMENT]: Add XXHash #290

sleeepyjack opened this issue Apr 5, 2023 · 1 comment · Fixed by #310
Assignees
Labels
helps: rapids Helps or needed by RAPIDS topic: performance Performance related issue type: feature request New feature request

Comments

@sleeepyjack
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

The current default hasher murmur3_32 is computational expensive and might lead to suboptimal performance in libcudf's hash join for when the build table is small enough so that it fits in L1 or L2$ (see rapidsai/cudf#10587).

Describe the solution you'd like

Libcudf has an open feature request (see rapidsai/cudf#12829), which proposes to use a faster hash function, namely XXHash. I propose adding XXHash as a second hasher to cuco and subsequently compare performance against murmur3_32.

Describe alternatives you've considered

No response

Additional context

No response

@sleeepyjack sleeepyjack added type: feature request New feature request helps: rapids Helps or needed by RAPIDS topic: performance Performance related issue labels Apr 5, 2023
@sleeepyjack sleeepyjack self-assigned this Apr 5, 2023
@bdice
Copy link
Contributor

bdice commented Apr 6, 2023

Awesome @sleeepyjack! Feel free to tag me for review if you'd like. I'd be very interested in seeing what libcudf can improve here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helps: rapids Helps or needed by RAPIDS topic: performance Performance related issue type: feature request New feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants