Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Move view classes to their own header #208

Closed
2 of 4 tasks
sleeepyjack opened this issue Aug 9, 2022 · 1 comment
Closed
2 of 4 tasks

[FEA] Move view classes to their own header #208

sleeepyjack opened this issue Aug 9, 2022 · 1 comment
Labels
type: feature request New feature request

Comments

@sleeepyjack
Copy link
Collaborator

sleeepyjack commented Aug 9, 2022

Part of #110 (Refactor of open address data structures)

Development branch: NVIDIA/cuCollections/refactor

Synopsis

Device view classes are currently implemented as nested classes of their associated data structures. This results in

TODOs

  • Regroup header files by data structure, e.g. include/cuco/detail/static_map/{kernels.cuh, impl.inl, views.cuh, ...}
  • Move views to their own header files
  • To disambiguate view types among data structures, use inline namespaces as shown here: https://godbolt.org/z/4qr8MK89o
  • Find a way to reduce code duplication when redefining member types/passing down tparams. Use case for CRTP, e.g., device_view<MapType>?

References

@PointKernel
Copy link
Member

completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request New feature request
Projects
None yet
Development

No branches or pull requests

2 participants