Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing/regression/* not used by CMake/CTest #741

Closed
alliepiper opened this issue Jun 25, 2020 · 4 comments · Fixed by #1901
Closed

testing/regression/* not used by CMake/CTest #741

alliepiper opened this issue Jun 25, 2020 · 4 comments · Fixed by #1901
Labels
thrust For all items related to Thrust.

Comments

@alliepiper
Copy link
Collaborator

alliepiper commented Jun 25, 2020

Naively trying to add these tests caused issues on windows due to CMAKE_OBJECT_PATH_MAX -- the paths to the object files exceed a system-dependent maximum number of characters. We should find a way to add these.

We could shorten the names, but it might be best to just integrate them with the other unit tests in testing/ or testing/<backend> and put bug metadata in comments.

@alliepiper alliepiper self-assigned this Mar 11, 2021
@alliepiper
Copy link
Collaborator Author

Just noticed that some of these aren't meant to be executed and just check that compilation succeeds, e.g:

https://github.com/NVIDIA/thrust/blob/main/testing/regression/gh_911__merge_by_key_wrong_element_type_default_comparator.cu

I can't find an existing build system for these, so I'm not sure which are meant to be run (if any). @brycelelbach do you recall if these are all intended to be compile only tests?

@brycelelbach
Copy link
Collaborator

Some of them are, some are meant to be run. It was an idea that never really came to fruition.

@alliepiper alliepiper removed their assignment Aug 17, 2021
@alliepiper alliepiper added the good first issue Good for newcomers. label Aug 17, 2021
@alliepiper
Copy link
Collaborator Author

We should incorporate the ones that run into the existing unit tests and remove this directory, since it's experimental / unused.

@alliepiper
Copy link
Collaborator Author

There's some overlap here with #807 -- once we have proper compile test support we could use that to check the "expected build failure" tests.

@alliepiper alliepiper removed the good first issue Good for newcomers. label May 11, 2022
@jrhemstad jrhemstad added the thrust For all items related to Thrust. label Feb 22, 2023
@github-project-automation github-project-automation bot moved this to Todo in CCCL Nov 8, 2023
@jarmak-nv jarmak-nv transferred this issue from NVIDIA/thrust Nov 8, 2023
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Jun 21, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
thrust For all items related to Thrust.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants