Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qwen end_id setting is wrong so cannot stop at right postition! #987

Closed
Liufeiran123 opened this issue Jan 27, 2024 · 3 comments
Closed
Labels

Comments

@Liufeiran123
Copy link

in file example/utils.py.
So I changed the end_id and All thing is right!

@kaiyux
Copy link
Member

kaiyux commented Feb 26, 2024

Hi @Liufeiran123 , thanks a lot for the kind reporting of the issue, we've fixed the issue in the internal codebase, and an update containing the fix will be pushed.

@kaiyux
Copy link
Member

kaiyux commented Feb 28, 2024

@Liufeiran123 We pushed an update to the main branch which should contain the fix of this issue, can you please verify it on the latest main branch? Thanks.

@nv-guomingz
Copy link
Collaborator

hi @Liufeiran123 do u still have further issue or question now? If not, we'll close it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants