Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade transformers to 4.45.2 #2465

Open
cupertank opened this issue Nov 19, 2024 · 4 comments
Open

Upgrade transformers to 4.45.2 #2465

cupertank opened this issue Nov 19, 2024 · 4 comments
Labels
question Further information is requested triaged Issue has been triaged by maintainers

Comments

@cupertank
Copy link

I'd like to use vLLM together with TensorRT-LLM in my project, but now it's not possible because of transformers versions.

vLLM requires transformers >= 4.45.2 and TensorRT-LLM has upper bound <= 4.45.1.

Is it possible to upgrade a minor version of transformers in TensorRT-LLM?

@hello-11 hello-11 added question Further information is requested triaged Issue has been triaged by maintainers labels Nov 21, 2024
@VALLIS-NERIA
Copy link

We have not tested yet but you can manually install a higher version of transformers. Usually there won't be much problem.

@cupertank
Copy link
Author

@VALLIS-NERIA it's not possible to do correctly with pypoetry, we cannot have a consistent lock file. I think there won't be problems with upgrading transformers by one minor version for future TRT-LLM releases. We already tested it with trnasformers 4.45.2, and it's totally fine

@Xarbirus
Copy link

Hi @VALLIS-NERIA! I have the same problem, could you please give it more attention?

@VALLIS-NERIA
Copy link

Hi @cupertank @Xarbirus , you can edit the requirements.txt if needed. Upgrading transformers offically is not that trival because TRT-LLM has to support many models. Maybe you have already noticed some models in examples directory have different transformers version in their own requirements.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested triaged Issue has been triaged by maintainers
Projects
None yet
Development

No branches or pull requests

4 participants