Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why Dit does not support pp_size > 1 #2427

Open
algorithmconquer opened this issue Nov 8, 2024 · 1 comment
Open

why Dit does not support pp_size > 1 #2427

algorithmconquer opened this issue Nov 8, 2024 · 1 comment
Assignees
Labels
question Further information is requested triaged Issue has been triaged by maintainers

Comments

@algorithmconquer
Copy link

In convert_checkpoint.py, the code is 'assert args.pp_size == 1, "PP is not supported yet."', why dit does not support pp_size > 1?

@hello-11 hello-11 added question Further information is requested triaged Issue has been triaged by maintainers labels Nov 11, 2024
@ChunhuanLin
Copy link

We thought DiT requeires lower latency rather than higher throughput. TP/CP can possibly reduce the model inference latency, however PP is not help with latency. That's the reason why we didn't support PP for DiT now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested triaged Issue has been triaged by maintainers
Projects
None yet
Development

No branches or pull requests

3 participants