Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window attention with huge window size(such as 65k) encountered shared mem error #1424

Closed
1 of 4 tasks
jesonxiang opened this issue Apr 8, 2024 · 2 comments · Fixed by #1688
Closed
1 of 4 tasks
Assignees
Labels
bug Something isn't working triaged Issue has been triaged by maintainers

Comments

@jesonxiang
Copy link

System Info

A800
trtllm v0.8

Who can help?

No response

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction

  1. build engine with large seqlen, eg. 256k input
  2. use huge window attention size, eg. 65k window
  3. inference with 256k prompt

Expected behavior

can infer normally by using multi-block decoding.

actual behavior

企业微信截图_557dce88-faf7-480f-af09-72ea2d6b22ef

additional notes

some informations may help:

  1. 65k window will also trigger multi-block mode
  2. the calculation of params.timesteps_per_block in function multi_block_grid_setup also use the max input length, but not the real windowed block size.
  3. shared mem usage in function smem_size_in_bytes leads the wrong space, core.
@jesonxiang jesonxiang added the bug Something isn't working label Apr 8, 2024
@byshiue
Copy link
Collaborator

byshiue commented May 15, 2024

Sorry for late response. It is a known issue about computing the share memory size when we use sliding window. We will fix it soon.

@byshiue byshiue added the triaged Issue has been triaged by maintainers label May 15, 2024
@PerkzZheng
Copy link
Collaborator

the fix will be included in next week's update (Tuesday). Feel free to give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged Issue has been triaged by maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants