add ipython import guard #11191
Merged
add ipython import guard #11191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nithin Rao Koluguri <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import IPython.display as ipd | ||
|
|
||
| HAVE_IPYTHON = True | ||
| except: |
Check notice
Code scanning / CodeQL
Except block handles 'BaseException' Note
Signed-off-by: Nithin Rao Koluguri <[email protected]>
nithinraok
force-pushed
the
handle_ipython_installation
branch
from
7be555d to
67b4b26
Compare
Signed-off-by: nithinraok <[email protected]>
Signed-off-by: Nithin Rao Koluguri <[email protected]>
Signed-off-by: nithinraok <[email protected]>
Signed-off-by: Nithin Rao Koluguri <[email protected]>
Signed-off-by: nithinraok <[email protected]>
nithinraok
added a commit
that referenced
this pull request
Nov 6, 2024
* add ipython import guard Signed-off-by: Nithin Rao Koluguri <[email protected]> * handle notebooks which uses vad_utils plot function: Signed-off-by: Nithin Rao Koluguri <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> * decrease line length Signed-off-by: Nithin Rao Koluguri <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> * small update to doc Signed-off-by: Nithin Rao Koluguri <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> --------- Signed-off-by: Nithin Rao Koluguri <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: nithinraok <[email protected]>
8 tasks
nithinraok
added a commit
that referenced
this pull request
Nov 6, 2024
* add ipython import guard * handle notebooks which uses vad_utils plot function: * Apply isort and black reformatting * decrease line length * Apply isort and black reformatting * small update to doc * Apply isort and black reformatting --------- Signed-off-by: Nithin Rao Koluguri <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: nithinraok <[email protected]>
lilyw97
pushed a commit
to lilyw97/NeMo
that referenced
this pull request
Nov 13, 2024
* add ipython import guard Signed-off-by: Nithin Rao Koluguri <[email protected]> * handle notebooks which uses vad_utils plot function: Signed-off-by: Nithin Rao Koluguri <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> * decrease line length Signed-off-by: Nithin Rao Koluguri <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> * small update to doc Signed-off-by: Nithin Rao Koluguri <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> --------- Signed-off-by: Nithin Rao Koluguri <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: nithinraok <[email protected]>
HuiyingLi
pushed a commit
to HuiyingLi/NeMo
that referenced
this pull request
Nov 15, 2024
* add ipython import guard Signed-off-by: Nithin Rao Koluguri <[email protected]> * handle notebooks which uses vad_utils plot function: Signed-off-by: Nithin Rao Koluguri <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> * decrease line length Signed-off-by: Nithin Rao Koluguri <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> * small update to doc Signed-off-by: Nithin Rao Koluguri <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> --------- Signed-off-by: Nithin Rao Koluguri <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: nithinraok <[email protected]>
yashaswikarnati
pushed a commit
that referenced
this pull request
Nov 21, 2024
* add ipython import guard Signed-off-by: Nithin Rao Koluguri <[email protected]> * handle notebooks which uses vad_utils plot function: Signed-off-by: Nithin Rao Koluguri <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> * decrease line length Signed-off-by: Nithin Rao Koluguri <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> * small update to doc Signed-off-by: Nithin Rao Koluguri <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> --------- Signed-off-by: Nithin Rao Koluguri <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: nithinraok <[email protected]>
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
* add ipython import guard Signed-off-by: Nithin Rao Koluguri <[email protected]> * handle notebooks which uses vad_utils plot function: Signed-off-by: Nithin Rao Koluguri <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> * decrease line length Signed-off-by: Nithin Rao Koluguri <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> * small update to doc Signed-off-by: Nithin Rao Koluguri <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> --------- Signed-off-by: Nithin Rao Koluguri <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: nithinraok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds import guard for ipython in vad_utils.py
Collection: ASR
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information