Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle type discussion #49

Closed
nreinicke opened this issue Nov 28, 2023 · 0 comments
Closed

Vehicle type discussion #49

nreinicke opened this issue Nov 28, 2023 · 0 comments

Comments

@nreinicke
Copy link
Collaborator

When building out a new PHEV vehicle model in #33, we added a new Vehicle abstraction. Right now, there are two implementations of vehicles:

  • SingleFuelVehicle: this represents vehicles that just take in a single fuel source (ICE, BEV, HEV).
  • DualFuelVehicle: this represents vehicles that take in two fuel sources (PHEV).

This distinction works for now but we might need a more granular splitting of types since each of the vehicles represented in the SingleFuelVehicle will have different energy consumption behavior (and eventually energy addition behavior). For example, a BEV can return a negative energy value from the internal routee-powertrain model and this should be added back into the battery.

Perhaps we should build out a unique Vehicle implementation for each of the following:

  • ICE (gas and diesel)
  • BEV
  • HEV
  • PHEV

If we do this, there might be some shared code/behavior between some of these and so it might involve create a set of functions to share between these models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant