Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query starting soc not propagating to state model #241

Closed
nreinicke opened this issue Jul 9, 2024 · 2 comments · Fixed by #254
Closed

Query starting soc not propagating to state model #241

nreinicke opened this issue Jul 9, 2024 · 2 comments · Fixed by #254
Labels
bug Something isn't working

Comments

@nreinicke
Copy link
Collaborator

nreinicke commented Jul 9, 2024

If I pass a query that looks like this:

[
    {
        "origin_x": -104.969307,
        "origin_y": 39.779021,
        "destination_x": -104.975360,
        "destination_y": 39.693005,
        "model_name": "2017_CHEVROLET_Bolt",
        "starting_soc_percent": 80,
    },
]

The resulting state model does not honor the setting of starting soc percent:

{'battery_state': {'format': {'floating_point': {'initial': 100.0}},
  'type': 'soc',
  'unit': 'percent'},
 'distance': {'distance_unit': 'miles', 'initial': 0.0},
 'energy_electric': {'energy_unit': 'kilowatt_hours', 'initial': 0.0},
 'time': {'initial': 0.0, 'time_unit': 'minutes'}}

When we are initializing the state model we use the default value of 100% and the starting soc percent does not get set properly.

@nreinicke nreinicke added the bug Something isn't working label Jul 9, 2024
@robfitzgerald
Copy link
Collaborator

robfitzgerald commented Sep 5, 2024

@nreinicke correct me if i'm wrong, but, your example doesn't look like a traversal_summary, but instead, a state_model. note how the distance, energy and time are all zeros:

{'battery_state': {'format': {'floating_point': {'initial': 100.0}},
  'type': 'soc',
  'unit': 'percent'},
 'distance': {'distance_unit': 'miles', 'initial': 0.0},
 'energy_electric': {'energy_unit': 'kilowatt_hours', 'initial': 0.0},
 'time': {'initial': 0.0, 'time_unit': 'minutes'}}

@nreinicke
Copy link
Collaborator Author

Oops yeah that's a typo, but the issue is that the initial number for battery state should be 80 rather than 100 since it should be overridden by the starting_soc_percent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants