Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update state config to be nested #137

Closed
nreinicke opened this issue Mar 11, 2024 · 1 comment
Closed

Update state config to be nested #137

nreinicke opened this issue Mar 11, 2024 · 1 comment

Comments

@nreinicke
Copy link
Collaborator

Right now the state config requires us to put the state key at the top of the toml file since if it's not then it will get nested inside another section. For example if we have the config:

[graph]
edge_list_input_file = "../data/tomtom_denver/edges-compass.csv.gz"
vertex_list_input_file = "../data/tomtom_denver/vertices-compass.csv.gz"
verbose = true

state = [
    { distance_unit = "kilometers", initial = 0.0 },
    { time_unit = "minutes", initial = 0.0 },
]

state would get nested under the graph key.

We could update this to have a nested entry so it could be placed anywhere in the toml file, something like:

[state_model]
state = [
    { distance_unit = "kilometers", initial = 0.0 },
    { time_unit = "minutes", initial = 0.0 },
]
@robfitzgerald
Copy link
Collaborator

We no longer rely on injecting state features at config time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants