cancel run does not work anymore

[brianlball]

run any of the SEB examples and try and cancel the run.

[nllong]

PAT: 2.7.1
OpenStudio Server: 2.7.1

The status gets set to Complete almost immediately, but the set of simulations that are queued are left in the queue to finish. Do you expect that all the queued simulations disappear upon clicking "cancel"?

[anyaelena]

working on two things:

1. Reviewing implications of introducing "pending cancellation" and "cancelled" statuses for analyses.
2. Deletion of all queued simulations when analysis in cancelled. Note that these do clear out quickly by failing with a undefined method status=' for nil:NilClass` error once the analysis has been cancelled. Not ideal but at least the workers do free up.

[anyaelena]

regarding queued datapoints not being removed, this should be ResqueJobs::RunSimulateDataPoint. I'll try to write a test for removing queued simulations and open PR.

[anyaelena]

ok. Running the "SEB_calibration_RepeatRun_2013" sample project from PAT against a locally deployed instance, canceling the run from PAT has no effect. The RunAnalysis Resque job remains active and datapoints keep running and completing.

[anyaelena]

I'm fairly sure that the issue is this:

1. we only clean up "queued" datapoints when the analysis is canceled: https://github.com/NREL/OpenStudio-server/blob/develop/server/app/models/analysis.rb#L172
2. the status is set to queued in the initialize block for the delayed jobs job,
3. which is called immediately before perform when we are using resque for queue management

So the datapoints that are queued w/Resque actually have status "na" and are being ignored when the analysis is canceled. I'm thinking through the cleanest fix to recommend.