Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add ability to not automatically download or load resource data to enable more thorough testing #423

Open
elenya-grant opened this issue Jan 20, 2025 · 0 comments

Comments

@elenya-grant
Copy link
Collaborator

Resource data initialization flexibility

in SolarResource, WindResource, HPCWindData and HPCSolarData - resource data is (or attempted to be) downloaded or loaded and formatted within the class initialization. In the case of the HPC resource data - this prevents testing of other functions due to errors raised when the file cannot be loaded (which is the case with any local testing). (Note - these classes live in hopp/simulation/technologies/resource/)

Another add-in that may be relevant here is to add the ability to save wind and solar resource data loaded from HPC datasets to a user-specified location (option to save it externally from the .h5 datasets hosted on HPCs - in a place like /scratch/user/resource_files/).

Proposed solution

  • add optional input to SiteInfo and Resource classes to download/load data or not
  • split some functionality from __init__() methods in these Resource classes into functions (ex: create_filepath(self))

Alternatives considered

Additional context

This is being requested based on conversations in PR #414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant