Bug report: providing production om value returns negative costs when using the custom financial model

[jaredthomas68]

Negative O&M from custom financial model when using om_production for battery

The OM for battery in custom financial model returns a negative result due to using the AEP of the battery, which is negative if the battery has charged more than it has discharged in the year. Another element of this is that battery OM costs may scale on nameplate energy and power, which is confusing for the om production inputs compared with other technologies. I think we ultimately should be able to scale O&M based on actual battery production/cycles/etc as well as nameplate energy and the input naming should make this clear.

How to reproduce

provide battery_om_per_mwh: 7750 in the HOPP input file to reference design 2 at https://github.com/NREL/ReferenceHybridSystemDesigns.

Relevant output

Traceback (most recent call last): File "/opt/anaconda3/envs/greenheart/lib/python3.11/site-packages/openmdao/core/system.py", line 2738, in _call_user_function yield File "/opt/anaconda3/envs/greenheart/lib/python3.11/site-packages/openmdao/core/explicitcomponent.py", line 271, in _compute_wrapper self.compute(self._inputs, self._outputs) File "/Users/*/Documents/programs/GreenHEART/greenheart/tools/optimization/openmdao.py", line 107, in compute greenheart_output = run_simulation(config) ^^^^^^^^^^^^^^^^^^^^^^ File "/Users/*/Documents/programs/GreenHEART/greenheart/simulation/greenheart_simulation.py", line 902, in run_simulation opex_annual, opex_breakdown_annual = he_fin.run_opex( ^^^^^^^^^^^^^^^^ File "/Users/*/Documents/programs/GreenHEART/greenheart/tools/eco/finance.py", line 547, in run_opex raise (RuntimeWarning(f"Battery OPEX returned as {battery_opex}")) RuntimeWarning: Battery OPEX returned as -33609037.02187817

HOPP version

HOPP version 3.1 installed from source using pip install -e . within a conda environment

System Information

• OS: macOS 14.7.2
• Python version: 3.11
• Library versions
  • greenheart 0.1.3
  • hopp 3.1
  • NREL-PySAM 4.2.0