Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: move away from using a global variable for DEFAULT_FIN_MODEL in the tests #398

Open
jaredthomas68 opened this issue Oct 29, 2024 · 0 comments
Labels
enhancement New feature or request medium priority Nice to have on the stove but not necessarily the front burner

Comments

@jaredthomas68
Copy link
Collaborator

Move away from using a global variable for DEFAULT_FIN_MODEL in the tests

I'd like to have use move away from global variables.

Proposed solution

We could use functions and/or .yaml files instead of global variables

Alternatives considered

Functions in a test module, input files, or local defaults for each test file instantiated inside each file (I don't like this option).

Additional context

The global variable DEFAULT_FIN_MODEL was edited in one test and all tests passed locally but for some reason the CI test run allowed the global variable change in the one file to impact the other tests, making it difficult to track down why the tests were failing.

@jaredthomas68 jaredthomas68 added enhancement New feature or request medium priority Nice to have on the stove but not necessarily the front burner labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium priority Nice to have on the stove but not necessarily the front burner
Projects
None yet
Development

No branches or pull requests

1 participant