Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdoor Air Details Followup #8550

Closed
9 of 10 tasks
mjwitte opened this issue Feb 19, 2021 · 4 comments · Fixed by #8596
Closed
9 of 10 tasks

Outdoor Air Details Followup #8550

mjwitte opened this issue Feb 19, 2021 · 4 comments · Fixed by #8596
Assignees

Comments

@mjwitte
Copy link
Contributor

mjwitte commented Feb 19, 2021

Issue overview

Unfinished items from #8529. Most of these were addressed in #8596 unless noted otherwise below.

  • Documentation - Output Details and Examples
  • Populate Times for Outdoor Air Limiting Factors During Occupancy subtable
  • Populate Average Outdoor Air For Each Outdoor Air Limiting Factors During Occupancy subtable
  • Possibly reorganize new variables - seems like lots of different places, not sure all the new variables are in appropriate places
  • Look for efficiency improvements (8529 was about -0.06% performance)
  • Unit tests - added in Unit test for Outdoor Air Details report #8685
  • QA the numbers in the report

Details

Some additional details for this issue (if relevant):

  • Version of EnergyPlus 9.5.0 I/O Freeze

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect files added in EnergyplusDevSupport\DefectFiles
  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
@LipingWang
Copy link
Contributor

LipingWang commented Feb 27, 2021

  1. In the table for “Total Outdoor Air by Zone,” "Time Above Zero When Unoccupied (hrs)" for total Facility was zero while this value for the thermal zones are non-zero.

  2. Please check the value for "Mechanical Ventilation" in the table "Total Outdoor Air by AirLoop." The value of "Mechanical Ventilation" in the table "Total Outdoor Air by AirLoop" is not consistent with the value of "Mechanical Ventilation" in the table " Outdoor Air Details: Total Outdoor Air by Zone" for total facility.

Use 5ZoneAirCooled.idf to test or Comment1and2_5ZoneAirCooledHVACS_ExampleFile.

@LipingWang
Copy link
Contributor

LipingWang commented Mar 2, 2021

  1. Please check the whether the OA schedule in the object for Design Specification: Outdoor Air was considered when sizing outdoor air airflow. After the value in OA schedule was changed to 0.5 from default 1 (constant throughout the year), Design Zone Outdoor Airflow - Voz [m3/s] and Minimum Dynamic Target Ventilation - Voz-dyn-min [m3/s] stayed unchanged.

MJW - 12 Mar 2021 - For the sizing calculations the schedule in the DesignSpecification:OutdoorAir is ignored, so I think this is correct.

@LipingWang
Copy link
Contributor

LipingWang commented Mar 3, 2021

  1. The "Time Above Voz-sum-dyn (hr)" needs to be checked. The "Time Above Voz-sum-dyn (hr)" is not consistent between the two tables: "Total Outdoor Air by AirLoop" and "Average Outdoor Air During Occupancy by Airloop" when occupancy schedule varies throughout the day.

MJW - 12 Mar 2021 - This appears to be correct, because every hour that counts as "Time Above Zero When Unoccupied" also counts as an hour for "time above Voz-sum-dyn". So for the comment 4 test file, time above during occupancy = 1044, time above zero when unoccupied = 5889, 1044+5889 = 6933 which is the time above during all hours. Maybe there's a better way to do this accounting?

@mjwitte
Copy link
Contributor Author

mjwitte commented Mar 12, 2021

@LipingWang I've pushed some fixes to #8596 which should fix all of the problems 1-4 here. I've also added some explanations above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants