TDD diffuser and dome inside and outside surface heat balance calculations not consistent with EngRef

[xuanluo113]

Issue overview

According to the Engineering Reference,

For conductive and convective heat gain, TDDs are treated as one entity with an effective thermal resistance (i.e. R-value) between the outside and inside surfaces. The outside face temperature of the dome and the inside face temperature of the diffuser are calculated as usual by the outside and inside heat balances respectively. The temperatures are then copied to the inside face of the dome and the outside face of the diffuser.

However, in EnergyPlus inside and outside surface heat balance calculations...

First, the surface outside temperature calculation is bypassed for TDD surface as their HeatTransferAlgorithm is assigned as HeatTransferModel_TDD. The TDD branch never gets accessed. These temperature values are initialized and remain static.
Then the values are copied to the TDD diffuser's outside temperature.

Second, the inside surf temperature of the diffuser is copied to the dome in the diffuser zone loop (e.g. Zone(1)), but later in the dome surface zone loop (e.g. Zone(2)), the inside surf temperature of the dome is recalculated and assigned to the reported value, overwriting the previously copied value.

Here is a snapshot of the summer design day results for the testfile DaylightingDeviceTubular.idf. The outside temperature of the diffuser and dome, and the inside temperature of the dome are not calculated correctly.

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Defect file added (list location of defect file here)
• Ticket added to Pivotal for defect (development team task)
• Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)