Add with_units_base feature
#1232
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1232 +/- ##
==========================================
- Coverage 84.35% 84.31% -0.04%
==========================================
Files 181 181
Lines 8375 8399 +24
==========================================
+ Hits 7065 7082 +17
- Misses 1310 1317 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Could you add an example at the end of this tutorial section showing with_units_base? https://nrel-sienna.github.io/PowerSystems.jl/stable/tutorials/creating_system/#Changing-System-Per-Unit-Settings
and mention in https://nrel-sienna.github.io/PowerSystems.jl/stable/explanation/per_unit/ with the other functions (halfway down). Thanks!
| end | ||
|
|
||
| """ | ||
| `with_units_base(function, system, units::Union{UnitSystem, String})` |
There was a problem hiding this comment.
Delete -- already taken care of with DocStringExtensions
| """ | ||
| `with_units_base(function, system, units::Union{UnitSystem, String})` | ||
|
|
||
| A "context manager" similar to `Logging.with_logger` that sets the system's units base to |
There was a problem hiding this comment.
| A "context manager" similar to `Logging.with_logger` that sets the system's units base to | |
| A "context manager" that sets the [`System`](@ref)'s [units base](@ref per_unit) to |
| """ | ||
| `set_units_base_system!(system::System, units::Union{UnitSystem, String})` |
There was a problem hiding this comment.
Closes #1229 by adding a new exported function
with_units_basethat serves as a "context manager" to execute a block of code as if the system's units base were set to a particular value.