String -> Identifier. WIP. #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 13.88% (diff: 17.07%)@@ master #229 diff @@
==========================================
Files 387 394 +7
Lines 10839 10993 +154
Methods 0 0
Messages 0 0
Branches 1547 1561 +14
==========================================
+ Hits 1491 1526 +35
- Misses 9271 9383 +112
- Partials 77 84 +7
|
RX14
suggested changes
Dec 21, 2016
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| return this == o || (o != null && getClass() == o.getClass() && id.equals(((AbstractIdentifier) o).id)); |
There was a problem hiding this comment.
This boolean expression is quite complex, maybe you could expand the code out to make it more readable.
There was a problem hiding this comment.
It could be done like this to make it more readable:
public boolean equals(Object other) {
if (other == this) return true;
if (other == null || getClass() != other.getClass()) return false;
return Objects.equals(id, ((AbstractIdentifier)other).id);
}
This was referenced Jan 2, 2017
ExE-Boss
added
breaking change
ExE-Boss
added a commit
to EB-Archive/NOVA-Core
that referenced
this pull request
Jan 7, 2017
ExE-Boss
removed
minecraft 1.7
|
Due to inactivity of the author, I’m taking over this PR at #238. |
RX14
removed
the
in progress
|
Can this be re-opened? |
RX14
added
the
in progress
|
The game runs, at least. Not sure how to test if it actually works tho. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #227. Depends on #226 (not for any technical reasons tho).
Still a lot of things to work out, see all the TODOs and FIXMEs scattered across the code.Still a few things to work out. (How do I test this in-game?)