Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icebergs restarting with wrong year #23

Open
sternalon opened this issue Feb 15, 2016 · 0 comments
Open

Icebergs restarting with wrong year #23

sternalon opened this issue Feb 15, 2016 · 0 comments

Comments

@sternalon
Copy link
Contributor

There is a bug in the iceberg code in the file icebergs_framework.F90, in the subroutine offset_berg_dates
This routine tries to see if there are any icebergs which were calved in the future, and if so, it subtracts an offset date.

In order to see if there are future bergs, the code compares the number computed in yearday with the number 367. However, 367 should be 373 (since 12*31+1)=373.

As a result of this bug, there are many icebergs which are given the incorrect start dates even when the code is running well.

This bug should be fixed by either
(i) Changing 367 to 373
(ii) The new version of the code will have unique iceberg id's, so this date offset should be removed completely.

(Interestingly, this bug only applies to icebergs calved after Christmas)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant