Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document units of 75 scattered variables #315

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

Hallberg-NOAA
Copy link
Member

Added or amended comments to document the units of 75 variables in 23 files in the src/core, src/initialization, src/ice_shelf and src/user directories that had been overlooked when the other variables in these files had their units documented. Only comments are changed, and all answers are bitwise identical.

@Hallberg-NOAA Hallberg-NOAA added the documentation Improvements or additions to documentation label Jan 28, 2023
@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #315 (f2c1382) into dev/gfdl (f6b4a7d) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

@@             Coverage Diff              @@
##           dev/gfdl     #315      +/-   ##
============================================
- Coverage     37.17%   37.17%   -0.01%     
============================================
  Files           265      265              
  Lines         74424    74424              
  Branches      13822    13822              
============================================
- Hits          27667    27665       -2     
- Misses        41672    41674       +2     
  Partials       5085     5085              
Impacted Files Coverage Δ
src/core/MOM_checksum_packages.F90 32.59% <ø> (ø)
src/core/MOM_density_integrals.F90 17.11% <ø> (ø)
src/core/MOM_porous_barriers.F90 31.25% <ø> (ø)
src/ice_shelf/user_shelf_init.F90 0.00% <ø> (ø)
src/initialization/MOM_grid_initialize.F90 90.96% <ø> (ø)
src/user/MOM_wave_interface.F90 1.24% <0.00%> (ø)
src/user/Phillips_initialization.F90 0.00% <0.00%> (ø)
src/user/SCM_CVMix_tests.F90 0.00% <ø> (ø)
src/user/benchmark_initialization.F90 95.95% <ø> (ø)
src/user/circle_obcs_initialization.F90 75.00% <ø> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Hallberg-NOAA Hallberg-NOAA force-pushed the misc_var_units branch 2 times, most recently from 3bb3486 to 02e3923 Compare January 31, 2023 09:43
  Added or amended comments to document the units of 75 variables in 23 files
in the src/core, src/initialization, src/ice_shelf and src/user directories that
had been overlooked when the other variables in these files had their units
documented.  Only comments are changed, and all answers are bitwise identical.
@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/18140 ✔️

@marshallward marshallward merged commit 454c5c6 into NOAA-GFDL:dev/gfdl Feb 2, 2023
@Hallberg-NOAA Hallberg-NOAA deleted the misc_var_units branch May 10, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants