+Rescale driver timestep variables and step_MOM args #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimensionally rescaled the internal variables with units of time in all of the top-level driver codes, from units of [s] to [T ~> s], including thing valid_time arguments to the various drivers' versions of convert_IOB_to_fluxes. All answers are bitwise identical in all cases that have been tested, although it should be noted that the mct_cap and nuopc_cap are not regularly tested as a part of the GFDL MOM6-examples test suite. These changes only apply to dimensional rescaling of timestep variables and the documentation of units.
Rescaled the dimensions of real time arguments to step_MOM and several other MOM routines that are called from the driver code, including shelf_calc_flux, iceberg_forces, iceberg_fluxes and step_offline, along with the routines offline_advection_ale and offline_advection_layer that are called subsequently. As a part of the development of this commit, it was found that one of the scaling factors for setting fluxes%ustar_berg was missing with the mct_cap, and this has been corrected. All answers and output are bitwise identical, but the scaling for several arguments in publicly visible interfaces have changed.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #260 +/- ##
=========================================
Coverage 37.12% 37.12%
=========================================
Files 263 263
Lines 73444 73444
Branches 13675 13675
=========================================
Hits 27268 27268
Misses 41151 41151
Partials 5025 5025
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Alper Altuntas has tested these changes with NCAR's test suite, and indicates (via e-mail) that there are no problems and that this PR is passing dimensional consistency testing for them. |
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/17708 ✔️ |
marshallward
approved these changes
Dec 15, 2022
This was referenced Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request applies dimensional rescaling to units of [T ~> s] for a
number of timestep variables in all of the driver codes and for some of the
arguments to step_MOM and 6 other routines. With this change, the rescaling
increasingly takes place at the driver level, especially on lines converting
time_types to real variables. All answers and output are bitwise identical, but
the scaling for several arguments in publicly visible interfaces have changed.
The commits in this PR include: