Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab: Fix nolib build directories #257

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

marshallward
Copy link
Member

The Gaea GitLab test configuration includes two no-library compilation tests for ocean-only and ice-ocean configurations. They are currently configured to run in the same directory.

Recently, several unusual I/O errors suggest problems due to concurrent testing of the builds. In order to rule out this possibility, this patch moves the ice-ocean test to a separate directory.

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #257 (cca704f) into dev/gfdl (5431682) will not change coverage.
The diff coverage is n/a.

❗ Current head cca704f differs from pull request most recent head 924d41b. Consider uploading reports for the commit 924d41b to get more accurate results

@@            Coverage Diff            @@
##           dev/gfdl     #257   +/-   ##
=========================================
  Coverage     37.09%   37.09%           
=========================================
  Files           263      263           
  Lines         73382    73382           
  Branches      13675    13675           
=========================================
  Hits          27219    27219           
  Misses        41130    41130           
  Partials       5033     5033           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marshallward marshallward requested a review from adcroft November 28, 2022 12:29
The Gaea GitLab test configuration includes two no-library compilation
tests for ocean-only and ice-ocean configurations.  They are currently
configured to run in the same directory.

Recently, several unusual I/O errors suggest problems due to concurrent
testing of the builds.  In order to rule out this possibility, this
patch moves the ice-ocean test to a separate directory.
@adcroft adcroft force-pushed the gitlab_nolib_dir_fix branch from 16016b8 to 924d41b Compare November 28, 2022 16:13
Copy link
Member

@adcroft adcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot - this was definitely wrong and likely working by chance. Submitted test at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/17554

@adcroft adcroft merged commit 798ba7a into NOAA-GFDL:dev/gfdl Nov 28, 2022
@marshallward marshallward deleted the gitlab_nolib_dir_fix branch April 21, 2023 15:15
marshallward pushed a commit that referenced this pull request Oct 25, 2023
* Move mct_cap/ to STALE_mct_cap/. mct cap is no longer supported and will soon be removed for good.

* remove mct from CI testing

* Remove mct test from github workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants