.testing: Use Fortran to generate tc inputs #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes the `build_{grid,data}.py` scripts from .testing's
tc4, along with the setup of the Python infrastructure used in the
.testing Makefile and GitHub Actions CI.
The Python scripts have been replaced with equivalent Fortran programs
which generate identical netCDF output.
A new rule (`preproc`) has been added to the .testing top Makefile for
generating the model input files.
The netCDF compiler dependenices are configured with autoconf, currently
duplicating the macros in `ac/configure.ac`. (NOTE: It may be possible
to share these with a common macro in ac/m4.
The configure script and Makefile are currently generated from
`configure.ac` and `autoreconf`. In the future, we could simply
pre-generate `configure` and add it to the repository.
This patch was motivated by the inability to install recent
netCDF-Python packages on systems with older gcc compilers, including
our main production machine. We could have possibly resolved this by
adding compiler configuration to pip, or perhaps reported the issue to
the netCDF-python project for them to resolve. But the costs of relying
on all this Python infrastructure is starting to exceed the benefits,
and I would recommend we excise it from our test suite.
marshallward
force-pushed
the
test_preproc_remove_python
branch
from
0961ed1 to
f68ce08
Compare
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #250 +/- ##
============================================
- Coverage 37.23% 37.17% -0.06%
============================================
Files 263 263
Lines 73060 73221 +161
Branches 13605 13638 +33
============================================
+ Hits 27201 27218 +17
- Misses 40841 40978 +137
- Partials 5018 5025 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hallberg-NOAA
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
I have reviewed this PR, and it looks good to me. This PR does fix our (currently broken) TC testing, and I have also verified that it works interactively.
I am willing to accept this PR, but I would prefer that it be refactored at some point to follow the MOM6 code and documentation standards.
This was referenced Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the
build_{grid,data}.pyscripts from .testing's tc4, along with the setup of the Python infrastructure used in the .testing Makefile and GitHub Actions CI.The Python scripts have been replaced with equivalent Fortran programs which generate identical netCDF output.
A new rule (
preproc) has been added to the .testing top Makefile for generating the model input files.The netCDF compiler dependenices are configured with autoconf, currently duplicating the macros in
ac/configure.ac. (NOTE: It may be possible to share these with a common macro in ac/m4.The configure script and Makefile are currently generated from
configure.acandautoreconf. In the future, we could simply pre-generateconfigureand add it to the repository.This patch was motivated by the inability to install recent netCDF-Python packages on systems with older gcc compilers, including our main production machine. We could have possibly resolved this by adding compiler configuration to pip, or perhaps reported the issue to the netCDF-python project for them to resolve. But the costs of relying on all this Python infrastructure is starting to exceed the benefits, and I would recommend we excise it from our test suite.