Skip to content

Commit

Permalink
+Specify CVMix parameter units and rescale CVMix
Browse files Browse the repository at this point in the history
  Specify the units of 5 parameters and applied dimensional rescaling to 14
MIN_THICKNESS or other length or viscosity parameters used in the CVMix code to
appropriate units like [Z ~> m] or [Z2 T-1 ~> m2 s-1], with related changes to
the rescaled units of several other internal variables.  Also added comments
describing a number of internal variables and their units in the MOM_CVMix and
MOM_tidal_mixing code.  The preliminary internal calculations in these routines
now work in these [Z ~> m] units a bit longer before being recast into MKS units
for the calls to the CVMix routines.  The unused KPP runtime parameters
CORRECT_SURFACE_LAYER_AVERAGE and FIRST_GUESS_SURFACE_LAYER_DEPTH have been
marked as obsolete in comments of the code since 2015, and have now been
formally obsoleted.  All answers are bitwise identical, but there are changes to
some MOM_parameter_doc files.
  • Loading branch information
Hallberg-NOAA authored and marshallward committed Dec 15, 2022
1 parent 60c1d7b commit 8ddd854
Show file tree
Hide file tree
Showing 6 changed files with 248 additions and 249 deletions.
3 changes: 2 additions & 1 deletion src/diagnostics/MOM_obsolete_params.F90
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ subroutine find_obsolete_params(param_file)

call obsolete_real(param_file, "ETA_TOLERANCE_AUX", only_warn=.true.)
call obsolete_real(param_file, "BT_MASS_SOURCE_LIMIT", 0.0)

call obsolete_real(param_file, "FIRST_GUESS_SURFACE_LAYER_DEPTH")
call obsolete_logical(param_file, "CORRECT_SURFACE_LAYER_AVERAGE")
call obsolete_int(param_file, "SEAMOUNT_LENGTH_SCALE", hint="Use SEAMOUNT_X_LENGTH_SCALE instead.")

call obsolete_logical(param_file, "MSTAR_FIXED", hint="Instead use MSTAR_MODE.")
Expand Down
Loading

0 comments on commit 8ddd854

Please sign in to comment.