Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sst_ncep and sst_anom from amip_interp_mod #1393

Open
laurenchilutti opened this issue Oct 16, 2023 · 1 comment
Open

Remove sst_ncep and sst_anom from amip_interp_mod #1393

laurenchilutti opened this issue Oct 16, 2023 · 1 comment
Assignees

Comments

@laurenchilutti
Copy link
Contributor

Describe the bug
sst_ncep and sst_anom should not be in amip_interp_mod and should be defined by the model components. Right now the dycore and the ice model seem to be the only components using these variables and they are defined in their respective components.

To Reproduce
Look at the code:

https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/blob/9af882c63615925e75a6b812ab4ab227a113f454/model/fv_grid_utils.F90#L210-L211

https://github.com/NOAA-GFDL/FMScoupler/blob/main/simple/ice_model.F90#L95

Expected behavior
sst_ncep and sst_anom should not be defined anywhere in FMS. We leave it up to components to define/allocate.

System Environment
N/A

Additional context
This change should not require any component updates.

@laurenchilutti
Copy link
Contributor Author

You can assign this issue to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants