Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create task_config member variable upon initialization #30

Merged
merged 8 commits into from
Jun 7, 2024
Merged

Create task_config member variable upon initialization #30

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6a7f175
Initial commit
DavidNew-NOAA Jun 7, 2024
ec0bdc9
Forgot a parenthesis
DavidNew-NOAA Jun 7, 2024
c62196f
Coding norms
DavidNew-NOAA Jun 7, 2024
0a7d200
Eliminated _runtime_config based on feedback from Rahul
DavidNew-NOAA Jun 7, 2024
2fae77d
Coding norms
DavidNew-NOAA Jun 7, 2024
1bd96b5
Remove some unnecessary stuff based on more feedback from Rahul
DavidNew-NOAA Jun 7, 2024
d68b1ed
Forgot parenthesis
DavidNew-NOAA Jun 7, 2024
c710e9f
Update src/wxflow/task.py
aerorahul Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 9 additions & 15 deletions src/wxflow/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,35 +30,29 @@ def __init__(self, config: Dict, *args, **kwargs):
"""

# Store the config and arguments as attributes of the object
self.config = AttrDict(config)
self._config = AttrDict(config)

for arg in args:
setattr(self, str(arg), arg)

for key, value in kwargs.items():
setattr(self, key, value)

# Pull out basic runtime keys values from config into its own runtime config
self.runtime_config = AttrDict()
runtime_keys = ['PDY', 'cyc', 'DATA', 'RUN', 'CDUMP'] # TODO: eliminate CDUMP and use RUN instead
for kk in runtime_keys:
try:
self.runtime_config[kk] = config[kk]
logger.debug(f'Deleting runtime_key {kk} from config')
del self.config[kk]
except KeyError:
raise KeyError(f"Encountered an unreferenced runtime_key {kk} in 'config'")
# Create task_config with everything that is inside _config and whatever the user chooses to
# extend it with when initializing a child subclass of Task. Only task_config should be referenced
# in any application, not _config.
self.task_config = self._config.copy()

# Any other composite runtime variables that may be needed for the duration of the task
# can be constructed here

# Construct the current cycle datetime object
self.runtime_config['current_cycle'] = add_to_datetime(self.runtime_config['PDY'], to_timedelta(f"{self.runtime_config.cyc}H"))
logger.debug(f"current cycle: {self.runtime_config['current_cycle']}")
self.task_config['current_cycle'] = add_to_datetime(self._config['PDY'], to_timedelta(f"{self._config.cyc}H"))
logger.debug(f"current cycle: {self.task_config['current_cycle']}")

# Construct the previous cycle datetime object
self.runtime_config['previous_cycle'] = add_to_datetime(self.runtime_config.current_cycle, -to_timedelta(f"{self.config['assim_freq']}H"))
logger.debug(f"previous cycle: {self.runtime_config['previous_cycle']}")
self.task_config['previous_cycle'] = add_to_datetime(self.task_config.current_cycle, -to_timedelta(f"{self._config['assim_freq']}H"))
logger.debug(f"previous cycle: {self.task_config['previous_cycle']}")

pass

Expand Down