Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NoahMP model #6

Merged
merged 119 commits into from
Jan 26, 2024
Merged

Update NoahMP model #6

merged 119 commits into from
Jan 26, 2024

Conversation

uturuncoglu
Copy link
Collaborator

This PR aims to bring fully coupled atmosphere-land configuration to UFS Weather Model. It also fix couple of issues related with the GitHub Action.

@uturuncoglu
update model and sync with ccpp version
ed4f4f8
@uturuncoglu
chack PR label to handle baseline change
81d8293
@uturuncoglu
minor fix for action
e5b6dba
@uturuncoglu
more minor fix for action
6504d21
@uturuncoglu
update cap to get similar results with ufs-land-driver and ERA5 forcing
60f646b
@uturuncoglu
fix for action
18c1d64
@uturuncoglu
fix syntax
e91082d
@uturuncoglu
update action
d642ffe
@uturuncoglu
update action
32543de
@uturuncoglu
loosen concretized method of environment
a6b4ab8
@uturuncoglu
update action
d4f3cf2
@uturuncoglu
disable host compatibility
d2babd7
@uturuncoglu
add support to cache new baseline
02a3dff
@uturuncoglu
more work in action
ee75501
@uturuncoglu
more work in action
a6f2d2e
@uturuncoglu
more work in action
f4de5f2
@uturuncoglu
Update datm_noahmp.yaml
dd4962e
@uturuncoglu
Update datm_noahmp.yaml
0f0e0e6
@uturuncoglu
Merge branch 'develop' into feature/nuopc_cap
f921857
@uturuncoglu
more work in action
956eb4c
@uturuncoglu
more work in action
6a69359
@uturuncoglu
more work in action
963ad0a
@uturuncoglu
more work in action
c5a356c
@uturuncoglu
artifical baseline change
f387526
@uturuncoglu
change syntax to override target entirely
6fcd57a
@uturuncoglu
artifical baseline change
7c15fbc
@uturuncoglu
more work in action
a78f13d
@uturuncoglu
more work in action
4a526be
@uturuncoglu
force to use double for reals
ea6f706
@uturuncoglu
more work in action
af52c71
@uturuncoglu uturuncoglu marked this pull request as ready for review July 28, 2023 05:44
@uturuncoglu uturuncoglu mentioned this pull request Jul 28, 2023
Merged
36 tasks
uturuncoglu and others added 20 commits August 9, 2023 13:52
@uturuncoglu
adjust CI test to work with new version of action
79734e2
@uturuncoglu
fix module name
b38ae84
remove unused section from test definition
a9e3739
@uturuncoglu
fix overwrite issue
8187357
@uturuncoglu
remove unused part from datm yaml file
64ae496
@uturuncoglu
Merge branch 'feature/nuopc_cap' of https://github.com/esmf-org/noahmp …
ae83c61 
…into feature/nuopc_cap
@uturuncoglu
fix action for YAML based ESMX run config
f0a507d
@uturuncoglu
sync model
9310ef1
@uturuncoglu
Merge branch 'feature/nuopc_cap' of https://github.com/esmf-org/noahmp …
8d33c9f 
…into feature/nuopc_cap
@uturuncoglu
sync with ccpp version
b9f1946
@uturuncoglu
remove Sa_ua and Sa_va from couling fields
00d4c49
@uturuncoglu
change default of output_freq to seconds
eb2e047
@uturuncoglu
sync model with ccpp version
f25293d
@uturuncoglu
fix github action
d9373a9
@uturuncoglu
chnage name of action
16ac0cd
@uturuncoglu
add debug options to build
3a0f222
@uturuncoglu
add debug options to build
87f6a26
@uturuncoglu
fix component testing action
691059b
@uturuncoglu
fix description
cf02f98
@uturuncoglu
more changes for coupled fields naming
5d8319d
@DeniseWorthen
Copy link

@uturuncoglu Who can review and approve this PR?

@uturuncoglu
Copy link
Collaborator Author

@barlage can do it.

barlage
barlage approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@barlage barlage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and consistent with the land model updates for HR3. I like the addition of the output "density" (low, med, high).

@jkbk2004
Copy link
Collaborator

@uturuncoglu @barlage All tests are done ate weather model. can you merge this pr? If you add jkbk2004 to this repo, I can handle merging.

@uturuncoglu uturuncoglu merged commit 0cd3e23 into NOAA-EMC:develop Jan 26, 2024
2 checks passed
@uturuncoglu
Copy link
Collaborator Author

@jkbk2004 done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barlage barlage barlage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uturuncoglu @DeniseWorthen @jkbk2004 @barlage