Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to spack-stack on non-production machines #34

Merged
merged 13 commits into from
Nov 20, 2023
Merged

Upgrade to spack-stack on non-production machines #34

merged 13 commits into from
Nov 20, 2023

Conversation

DavidHuber-NOAA
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA commented Nov 17, 2023 •
edited
Loading

This upgrades the modules for gfs-utils to spack-stack/1.5.1. This has been tested thoroughly on Hera and somewhat on Orion. Builds were tested on S4, Jet, and WCOSS2. Backwards compatibility had to be added into the CMakeLists.txt and source files for mkgfsawps and fbwndgfs applications for w3emc and ip to continue support for WCOSS2.

Resolves #23

aerorahul
aerorahul requested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions to properly invoke preprocessor and provide compile time definitions.

src/enkf_chgres_recenter_nc.fd/CMakeLists.txt Outdated Show resolved Hide resolved
src/fbwndgfs.fd/CMakeLists.txt Outdated Show resolved Hide resolved
src/mkgfsawps.fd/CMakeLists.txt Outdated Show resolved Hide resolved
@DavidHuber-NOAA @aerorahul
Simplify w3em_version checking
f27614d 
Co-authored-by: Rahul Mahajan <[email protected]>
@DavidHuber-NOAA
Copy link
Contributor Author

@aerorahul Thanks for the suggestions! I reworked the CMakeLists.txt files to better check for version numbers and removed the -fpp flags while renaming the three source files to use .F or .F90 extensions where preprocessing was needed. This compiled on both Hera and WCOSS2.

aerorahul
aerorahul approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thank you for including the suggested changes.

@aerorahul aerorahul merged commit 427d467 into NOAA-EMC:develop Nov 20, 2023
@DavidHuber-NOAA DavidHuber-NOAA mentioned this pull request Nov 20, 2023
Merged
7 tasks
@DavidHuber-NOAA DavidHuber-NOAA deleted the feature/spack-stack branch December 19, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerorahul aerorahul aerorahul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to spack-stack libraries on non-production machines
2 participants
@DavidHuber-NOAA @aerorahul