Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary SIMD instruction sets from ccpp/CMakeLists.txt #220

Merged
merged 5 commits into from
Jan 7, 2021
Merged

Remove unnecessary SIMD instruction sets from ccpp/CMakeLists.txt #220

merged 5 commits into from
Jan 7, 2021

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Dec 31, 2020 •
edited
Loading

Description

When option SIMDMULTIARCH is used at compile time (currently only on Jet), four SIMD instruction sets are compiled into the executable. The fv3atm ccpp/CMakeLists.txt defines these flags identically to the ufs-weather-model.

The changes in the associated PRs listed below require making corresponding changes in fv3atm in this PR. The changes here also reflect a previous change in ufs-weather-model which set AVX to OFF when SIMDMULTIARCH is ON.

Note: this change in fv3atm is a short-lived change, only meant to speed up compiling and running regression tests on jet so that forthcoming PRs that will address the unnecessary complexity of defining compiler flags in ccpp/CMakeLists.txt and other IPD-related cleanup work can progress faster (see #214, for example).

Also included: update submodule pointer for GFDL_atmos_cubed_sphere for the change described in NOAA-EMC/GFDL_atmos_cubed_sphere#49 (initialize cld_amt to zero for regional runs)

Issue(s) addressed

n/a

Testing

See ufs-community/ufs-weather-model#353.

Dependencies

NCAR/ccpp-physics#539
NOAA-EMC/GFDL_atmos_cubed_sphere#49
#220
ufs-community/ufs-weather-model#353

This was referenced Dec 31, 2020
Merged
Merged
@climbfuji climbfuji marked this pull request as ready for review January 4, 2021 21:43
@climbfuji climbfuji force-pushed the simd_update_20201231 branch from c7b8afd to 45487a6 Compare January 6, 2021 23:58
@climbfuji climbfuji force-pushed the simd_update_20201231 branch from 45487a6 to 5276653 Compare January 6, 2021 23:59
@climbfuji
Copy link
Collaborator Author

@DusanJovic-NOAA @junwang-noaa ready to merge

@DusanJovic-NOAA DusanJovic-NOAA merged commit 45618a9 into NOAA-EMC:develop Jan 7, 2021
DomHeinzeller pushed a commit to NOAA-GSL/fv3atm that referenced this pull request Feb 23, 2021
@climbfuji @pjpegion
@ShanSunNOAA @mark-a-potts @SMoorthi-emc @dustinswales @junwang-noaa @XiaqiongZhou-NOAA @ValeryYudin-NOAA @mdtoyNOAA @XiaSun-Atmos
Update gsl/develop from develop 2021/02/22 (#73)
c48b45a 
* Fix for updating stochastic physics on separate time-step. (NOAA-EMC#199)

This bug fix allows the random patterns in the stochastic physics persist the for a period of time (defined as SKEBINT,SPPTINT, etc.) before calculating new patterns.
The fix is to move the allocation of the saved variables into the init section of stochastic_physics_wrapper, and remove the deallocates in the run section.

* Bug fixes in (1) running with frac_grid=T and GFDL MP and (2) restarting with frac_grid=T (NOAA-EMC#204)

* -- Pointing to Moorthi's modifications in ccpp/physics, which fixed the crash when running GFDL MP with frac_grid=T;
-- Not setting fice to zero in order to leave lake ice untouched;
-- Restart in the coupled model with the default physics is reproducible, if bad water temperature is only filtered at initial time;
Co-authored-with: Shrinivas Moorthi <[email protected]>
Co-authored-with: Denise Worthen <[email protected]>

* jedi-ufs with ccpp-physics submodule update (contains NOAA-EMC#201) (NOAA-EMC#211)

* updated CMakeLists.txt
* Changes for JEDI linking/control
* Update .gitmodules and submodule pointer for ccpp-physics for code review and testing
* Revert change to .gitmodules and update submodule pointer for ccpp-physics

Co-authored-by: Mark Potts <[email protected]>

* Final-final GFS v16 updates / restart reproducibility bugfixes (NOAA-EMC#212)

* updates the submodule pointer for ccpp-physics for the final-final (!) GFS v16 physics updates
* fixes a bug in io/FV3GFS_io.F90 to obtain restart reproducibility for uncoupled and coupled runs - contributed by @SMoorthi-emc

Co-authored-by: Shrinivas.Moorthi <[email protected]>

* RRTMGP coupling to Thompson MP in ccpp-physics (NOAA-EMC#208)

* Updated physics. Added infrastructure to FV3 to handle new GP capabilities. Thompson MP, LW scattering, Use of LW-jacobian to update surface tendencies.
* Some small changes to work with physics improvements to RRTMGP.
* RRTMGP working with Thompson MP.
* Updated .gitmodules.
* Updated physics. New interstitials.
* Synced with NCAR/master
* Updated ccpp-physics
* Updated physics submodule.
* Cleanup
* Update physics
* Updated physics submodule pointer.
* Updated physics submodule hash.

* Minor bug fixes to CCPP UGWP (update submodule pointer for ccpp-physics) (NOAA-EMC#216)

Update the submodule pointer for ccpp-physics for minor bugfixes in CCPP's Unified Gravity Wave Drag parameterization.

* Remove IPD (step 1) (NOAA-EMC#215)

Remove all IPD source files that are not needed to compile with CCPP. Update gfsphysics/CMakeLists.txt and gfsphysics/GFS_layer/GFS_driver.F90 so that the code compiles after removing IPD sources.

Also: update submodule pointer for GFDL_atmos_cubed_sphere to include PR NOAA-EMC/GFDL_atmos_cubed_sphere#48 ("Removed use of mpp_node for use with FMS 2020.04").

* Update submodule pointers for ccpp-framework (ccpp_prebuild bugfix) and ccpp-physics (RRTMGP GFDL-MP bugfix) (NOAA-EMC#218)

Update the submodule pointers for ccpp-framework and ccpp-physics for the changes described in
NCAR/ccpp-framework#343 and NCAR/ccpp-physics#536.

* Remove unnecessary SIMD instruction sets from ccpp/CMakeLists.txt (NOAA-EMC#220)

* Remove additional/unnecessary SIMD instruction sets from ccpp/CMakeLists.txt

* Implementation of CCPP timestep_init and timestep_final phases (NOAA-EMC#217)

- replace calls to CCPP step `time_vary` with `timestep_init` in `atmos_model.F90`, add call to CCPP step `timestep_final` 
- update `ccpp/driver/CCPP_driver.F90` with calls to CCPP `timestep_init` and `timestep_final`
- add `h2o_def.f` and `ozne_def.` to `ccpp_prebuild_config.py`
- update of `gfsphysics/GFS_layer/GFS_typedefs.F90`: cleanup work for o3 and h2o physics (required by the updates to the CCPP time vary physics)
- update metadata in `gfsphysics/GFS_layer/GFS_typedefs.meta` for the above changes, and clean up the index used for the surface wind enhancement due to convection in the `phy_f2d` array (use proper index, not just the last entry in the array)

* add radiation_clouds_thompson_dependency in ccpp physics  (NOAA-EMC#225)

* using radiation_clouds_thompson_dependency ccpp physics branch
* point to ccpp master branch

* Remove IPD steps 3 and 5 (NOAA-EMC#224)

* Implementation of CCPP timestep_init and timestep_final phases in fv3atm; cleanup work in GFS_typedefs for o3 and h2o physics as a result of the changes to the time vary physics in CCPP
* Use proper index variable for surface wind enhancement due to convection in phy_f2d array in GFS_typedefs.{F90,meta}, move code to clear diagnostic buckets using GFS DDT bound procedures from atmos_model.F90 to CCPP_driver.F90
* First step of cleanup process: remove CCPP preprocessor directives, remove parts of unused IPD code, update cmake build system, Delete IPD source code, Replace IPD DDTs with GFS DDTs, Bugfix in atmos_model.F90; add missing call to GFS_externaldiag_populate, Move contents of gfsphysics/{CCPP_layer,GFS_layer} to ccpp/{data,driver}, entirely deleted IPD typedefs, Rename module GFS_driver to GFS_init
* Fix indentation in ccpp/data/CMakeLists.txt and ccpp/driver/CMakeLists.txt
* Add logic to set DYN32 depending on 32BIT setting
* Pass preprocessor directive GFS_TYPES to dycore to enable use of GFS data types
* Compile GFS_diagnostics.F90 without optimization, this leads to out of memory errors on wcoss_dell_p3

* Add CCPP rrtmgp fix (NOAA-EMC#237)

* ccpp physics merged with top of master
* point back to ccpp master branch

* Update develop from NOAA-GSL: RUC ice, MYNN sfclay, stochastic land perturbations (NOAA-EMC#239)

* Update .gitmodules and submodule pointers for ccpp-framework and ccpp-physics for gsl/develop branch
* RUC ice for gsl/develop (replaces #54 and #56) (#60) Implementation of RUC LSM ice model in CCPP
* Fix bug in gfsphysics/GFS_layer/GFS_typedefs.F90 from merge
* Remove lsm_ruc_sfc_sice from suite FV3_GSD_v0_unified_ugwp_suite and update submodule pointer for ccpp-physics
* Remove sfc_sice from ccpp/suites/suite_FV3_GSD_v0_unified_ugwp_suite.xml
* Update gsl/develop from develop 2020/12/08 (#61)
* Fix for updating stochastic physics on separate time-step. (NOAA-EMC#199)
This bug fix allows the random patterns in the stochastic physics persist the for a period of time (defined as SKEBINT,SPPTINT, etc.) before calculating new patterns.
The fix is to move the allocation of the saved variables into the init section of stochastic_physics_wrapper, and remove the deallocates in the run section.
* Bug fixes in (1) running with frac_grid=T and GFDL MP and (2) restarting with frac_grid=T (NOAA-EMC#204)
* -- Pointing to Moorthi's modifications in ccpp/physics, which fixed the crash when running GFDL MP with frac_grid=T;
-- Not setting fice to zero in order to leave lake ice untouched;
-- Restart in the coupled model with the default physics is reproducible, if bad water temperature is only filtered at initial time;
Co-authored-with: Shrinivas Moorthi <[email protected]>
Co-authored-with: Denise Worthen <[email protected]>
* Revert change to .gitmodules and update submodule pointer for ccpp-physics
* Update submodule pointer for ccpp-physics - MYNN surface layer updates and bugfixes (#63)
* Land stochastic perturbations (wrapper PR for #65) (#68)
* Move initialization of stochastic physics after the physics
initialization in CCPP.
* Add albedo variables to land perturbations with lndp_type=2 option. Change to accommodate soil perturbations with RUC LSM.
* Max/min soil moisture variables are introduced via GFS_Control_type
variables instead of through the use of namelist_soilveg*. This is a
more flexible way for different LSMs.
* Added pores and resid variables for max/min soil moisture to GFS_typedefs.f90.
* Remove tracer_sanitizer from all suites and from CCPP prebuild config
* Add namelist option to apply land surface perturbations at every time step, clean up stochastic_physics/stochastic_physics_wrapper.F90
* Stochastic land perturbations: add roughness length over land to the perturbed variables (#70)
* Added roughness length over land to the perturbed variables.
* Bugfix in gfsphysics/GFS_layer/GFS_typedefs.F90: remove Diag%cldcov, in particular the reset call because the variable is not allocated
* Update .gitmodules and submodule pointer for GFDL_atmos_cubed_sphere for code review and testing
* Revert change to .gitmodules for ccpp-physics, update submodule pointer for ccpp-physics
* Revert change to .gitmodules and update submodule pointer for GFDL_atmos_cubed_sphere
Co-authored-by: DomHeinzeller <[email protected]>
Co-authored-by: Phil Pegion <[email protected]>
Co-authored-by: shansun6 <[email protected]>
Co-authored-by: tanyasmirnova <[email protected]>

* Dycore change to add an option to zero-gradient BC for height advection and change dz_min as a namelist input (NOAA-EMC#232)

* Point dycore to a personal branch
* Point to new version of dycore
* Update the dycore version
* Update the dycore version
* Point to NOAA-EMC dev/emc dycore branch

* Remove gnumake build remnants, change v16beta to v16 (NOAA-EMC#234)

* Remove gnumake files
* Replace v16beta with v16 for all CCPP suites
* Remove unused CCPP_INCLUDE_DIRS/CCPP_LIB_DIRS from ccpp/CMakeLists.txt

* Move LSM vegetation lookup tables into CCPP, clean up RUC snow cover on ice initialization  (remove IPD step 2) (NOAA-EMC#244)

* Move LSM vegetation lookup tables into CCPP, clean up RUC snow cover on ice initialization
* Revert change to .gitmodules and update submodule pointer for ccpp-physics

* UGWP v0 v1 combined (NOAA-EMC#241)

* .gitmodules/gsl atmos-cubed cccp-fram cccp/physics
* update fv3atm from NOAA-EMC Jan 9
* new suite_FV3_GFS_v16b_ugwpv1.xml and modifications Jan 11/2021
* Added new logical flag do_ugwp_v0_nst_only which allows non-stationary drag from ugwp_v0 to be run with GSL drag suite
* Fix formatting in ccpp/data/GFS_typedefs.*
* Clean up allocation of arrays in ccpp/data/GFS_typedefs.F90, add active attribute (pass 1) to ccpp/data/GFS_typedefs.meta, strip trailing whitespaces from both
* Update and cleanup of metadata for UGWPv0, UGWPv1, drag suite
* Reorganize UGWP diagnostic variables in data/GFS_typedefs.{F90,meta}
* Bugfix for uninitialized data in ccpp/data/GFS_typedefs.F90
* Update submodule pointer for ccpp-physics
* Allocate 3d diagnostic arrays as dummy arrays if not used

Co-authored-by: valery.yudin <[email protected]>
Co-authored-by: Michael Toy <[email protected]>

* SDF for GFSv16 with Thompson (NOAA-EMC#238)

* SDF for GFSv16 with Thompson
* Delete suite_FV3_GFS_v16beta_thompson.xml
* update to new commit of Thompson MP in ccpp physics

Co-authored-by: Phil Pegion <[email protected]>
Co-authored-by: shansun6 <[email protected]>
Co-authored-by: Mark Potts <[email protected]>
Co-authored-by: Shrinivas.Moorthi <[email protected]>
Co-authored-by: dustinswales <[email protected]>
Co-authored-by: Jun Wang <[email protected]>
Co-authored-by: XiaqiongZhou-NOAA <[email protected]>
Co-authored-by: valery.yudin <[email protected]>
Co-authored-by: Michael Toy <[email protected]>
Co-authored-by: XiaSun-NOAA <[email protected]>
junwang-noaa added a commit that referenced this pull request Dec 13, 2021
@climbfuji @DomHeinzeller
@pjpegion @ShanSunNOAA @tanyasmirnova @mark-a-potts @SMoorthi-emc @dustinswales @junwang-noaa @XiaqiongZhou-NOAA @ValeryYudin-NOAA @mdtoyNOAA @XiaSun-Atmos @SamuelTrahanNOAA @hannahcbarnes
Merge NOAA-GSL gsl/develop into develop, update CCPP SDFs (#435)
e7687f4 
* Update .gitmodules and submodule pointers for ccpp-framework and ccpp-physics for gsl/develop branch

* RUC ice for gsl/develop (replaces #54 and #56) (#60)

Implementation of RUC LSM ice model in CCPP

* Squash-merge climbfuji:rucice_gfsv16dzmin into gsl/develop

* Fix bug in gfsphysics/GFS_layer/GFS_typedefs.F90 from merge

* Remove lsm_ruc_sfc_sice from suite FV3_GSD_v0_unified_ugwp_suite and update submodule pointer for ccpp-physics

* Remove sfc_sice from ccpp/suites/suite_FV3_GSD_v0_unified_ugwp_suite.xml

* Update submodule pointer for ccpp-physics

* Revert change to .gitmodules and update submodule pointer for ccpp-physics

Co-authored-by: Dom Heinzeller <[email protected]>

* Update gsl/develop from develop 2020/12/08 (#61)

* Fix for updating stochastic physics on separate time-step. (#199)

This bug fix allows the random patterns in the stochastic physics persist the for a period of time (defined as SKEBINT,SPPTINT, etc.) before calculating new patterns.
The fix is to move the allocation of the saved variables into the init section of stochastic_physics_wrapper, and remove the deallocates in the run section.

* Bug fixes in (1) running with frac_grid=T and GFDL MP and (2) restarting with frac_grid=T (#204)

* -- Pointing to Moorthi's modifications in ccpp/physics, which fixed the crash when running GFDL MP with frac_grid=T;
-- Not setting fice to zero in order to leave lake ice untouched;
-- Restart in the coupled model with the default physics is reproducible, if bad water temperature is only filtered at initial time;
Co-authored-with: Shrinivas Moorthi <[email protected]>
Co-authored-with: Denise Worthen <[email protected]>

* Revert change to .gitmodules and update submodule pointer for ccpp-physics

Co-authored-by: Phil Pegion <[email protected]>
Co-authored-by: shansun6 <[email protected]>

* Update submodule pointer for ccpp-physics - MYNN surface layer updates and bugfixes (#63)

* Land stochastic perturbations (wrapper PR for #65) (#68)

* Move initialization of stochastic physics after the physics
initialization in CCPP.
* Add albedo variables to land perturbations with lndp_type=2 option. Change to accommodate soil perturbations with RUC LSM.

* Max/min soil moisture variables are introduced via GFS_Control_type
variables instead of through the use of namelist_soilveg*. This is a
more flexible way for different LSMs.

* Added pores and resid variables for max/min soil moisture to GFS_typedefs.f90.

* Remove tracer_sanitizer from all suites and from CCPP prebuild config

* Add namelist option to apply land surface perturbations at every time step, clean up stochastic_physics/stochastic_physics_wrapper.F90

Co-authored-by: tanyasmirnova <[email protected]>

* Stochastic land perturbations: add roughness length over land to the perturbed variables (#70)

* Added roughness length over land to the perturbed variables.
* Bugfix in gfsphysics/GFS_layer/GFS_typedefs.F90: remove Diag%cldcov, in particular the reset call because the variable is not allocated

Co-authored-by: Dom Heinzeller <[email protected]>

* Update gsl/develop from develop 2021/02/22 (#73)

* Fix for updating stochastic physics on separate time-step. (#199)

This bug fix allows the random patterns in the stochastic physics persist the for a period of time (defined as SKEBINT,SPPTINT, etc.) before calculating new patterns.
The fix is to move the allocation of the saved variables into the init section of stochastic_physics_wrapper, and remove the deallocates in the run section.

* Bug fixes in (1) running with frac_grid=T and GFDL MP and (2) restarting with frac_grid=T (#204)

* -- Pointing to Moorthi's modifications in ccpp/physics, which fixed the crash when running GFDL MP with frac_grid=T;
-- Not setting fice to zero in order to leave lake ice untouched;
-- Restart in the coupled model with the default physics is reproducible, if bad water temperature is only filtered at initial time;
Co-authored-with: Shrinivas Moorthi <[email protected]>
Co-authored-with: Denise Worthen <[email protected]>

* jedi-ufs with ccpp-physics submodule update (contains #201) (#211)

* updated CMakeLists.txt
* Changes for JEDI linking/control
* Update .gitmodules and submodule pointer for ccpp-physics for code review and testing
* Revert change to .gitmodules and update submodule pointer for ccpp-physics

Co-authored-by: Mark Potts <[email protected]>

* Final-final GFS v16 updates / restart reproducibility bugfixes (#212)

* updates the submodule pointer for ccpp-physics for the final-final (!) GFS v16 physics updates
* fixes a bug in io/FV3GFS_io.F90 to obtain restart reproducibility for uncoupled and coupled runs - contributed by @SMoorthi-emc

Co-authored-by: Shrinivas.Moorthi <[email protected]>

* RRTMGP coupling to Thompson MP in ccpp-physics (#208)

* Updated physics. Added infrastructure to FV3 to handle new GP capabilities. Thompson MP, LW scattering, Use of LW-jacobian to update surface tendencies.
* Some small changes to work with physics improvements to RRTMGP.
* RRTMGP working with Thompson MP.
* Updated .gitmodules.
* Updated physics. New interstitials.
* Synced with NCAR/master
* Updated ccpp-physics
* Updated physics submodule.
* Cleanup
* Update physics
* Updated physics submodule pointer.
* Updated physics submodule hash.

* Minor bug fixes to CCPP UGWP (update submodule pointer for ccpp-physics) (#216)

Update the submodule pointer for ccpp-physics for minor bugfixes in CCPP's Unified Gravity Wave Drag parameterization.

* Remove IPD (step 1) (#215)

Remove all IPD source files that are not needed to compile with CCPP. Update gfsphysics/CMakeLists.txt and gfsphysics/GFS_layer/GFS_driver.F90 so that the code compiles after removing IPD sources.

Also: update submodule pointer for GFDL_atmos_cubed_sphere to include PR NOAA-EMC/GFDL_atmos_cubed_sphere#48 ("Removed use of mpp_node for use with FMS 2020.04").

* Update submodule pointers for ccpp-framework (ccpp_prebuild bugfix) and ccpp-physics (RRTMGP GFDL-MP bugfix) (#218)

Update the submodule pointers for ccpp-framework and ccpp-physics for the changes described in
NCAR/ccpp-framework#343 and NCAR/ccpp-physics#536.

* Remove unnecessary SIMD instruction sets from ccpp/CMakeLists.txt (#220)

* Remove additional/unnecessary SIMD instruction sets from ccpp/CMakeLists.txt

* Implementation of CCPP timestep_init and timestep_final phases (#217)

- replace calls to CCPP step `time_vary` with `timestep_init` in `atmos_model.F90`, add call to CCPP step `timestep_final` 
- update `ccpp/driver/CCPP_driver.F90` with calls to CCPP `timestep_init` and `timestep_final`
- add `h2o_def.f` and `ozne_def.` to `ccpp_prebuild_config.py`
- update of `gfsphysics/GFS_layer/GFS_typedefs.F90`: cleanup work for o3 and h2o physics (required by the updates to the CCPP time vary physics)
- update metadata in `gfsphysics/GFS_layer/GFS_typedefs.meta` for the above changes, and clean up the index used for the surface wind enhancement due to convection in the `phy_f2d` array (use proper index, not just the last entry in the array)

* add radiation_clouds_thompson_dependency in ccpp physics  (#225)

* using radiation_clouds_thompson_dependency ccpp physics branch
* point to ccpp master branch

* Remove IPD steps 3 and 5 (#224)

* Implementation of CCPP timestep_init and timestep_final phases in fv3atm; cleanup work in GFS_typedefs for o3 and h2o physics as a result of the changes to the time vary physics in CCPP
* Use proper index variable for surface wind enhancement due to convection in phy_f2d array in GFS_typedefs.{F90,meta}, move code to clear diagnostic buckets using GFS DDT bound procedures from atmos_model.F90 to CCPP_driver.F90
* First step of cleanup process: remove CCPP preprocessor directives, remove parts of unused IPD code, update cmake build system, Delete IPD source code, Replace IPD DDTs with GFS DDTs, Bugfix in atmos_model.F90; add missing call to GFS_externaldiag_populate, Move contents of gfsphysics/{CCPP_layer,GFS_layer} to ccpp/{data,driver}, entirely deleted IPD typedefs, Rename module GFS_driver to GFS_init
* Fix indentation in ccpp/data/CMakeLists.txt and ccpp/driver/CMakeLists.txt
* Add logic to set DYN32 depending on 32BIT setting
* Pass preprocessor directive GFS_TYPES to dycore to enable use of GFS data types
* Compile GFS_diagnostics.F90 without optimization, this leads to out of memory errors on wcoss_dell_p3

* Add CCPP rrtmgp fix (#237)

* ccpp physics merged with top of master
* point back to ccpp master branch

* Update develop from NOAA-GSL: RUC ice, MYNN sfclay, stochastic land perturbations (#239)

* Update .gitmodules and submodule pointers for ccpp-framework and ccpp-physics for gsl/develop branch
* RUC ice for gsl/develop (replaces #54 and #56) (#60) Implementation of RUC LSM ice model in CCPP
* Fix bug in gfsphysics/GFS_layer/GFS_typedefs.F90 from merge
* Remove lsm_ruc_sfc_sice from suite FV3_GSD_v0_unified_ugwp_suite and update submodule pointer for ccpp-physics
* Remove sfc_sice from ccpp/suites/suite_FV3_GSD_v0_unified_ugwp_suite.xml
* Update gsl/develop from develop 2020/12/08 (#61)
* Fix for updating stochastic physics on separate time-step. (#199)
This bug fix allows the random patterns in the stochastic physics persist the for a period of time (defined as SKEBINT,SPPTINT, etc.) before calculating new patterns.
The fix is to move the allocation of the saved variables into the init section of stochastic_physics_wrapper, and remove the deallocates in the run section.
* Bug fixes in (1) running with frac_grid=T and GFDL MP and (2) restarting with frac_grid=T (#204)
* -- Pointing to Moorthi's modifications in ccpp/physics, which fixed the crash when running GFDL MP with frac_grid=T;
-- Not setting fice to zero in order to leave lake ice untouched;
-- Restart in the coupled model with the default physics is reproducible, if bad water temperature is only filtered at initial time;
Co-authored-with: Shrinivas Moorthi <[email protected]>
Co-authored-with: Denise Worthen <[email protected]>
* Revert change to .gitmodules and update submodule pointer for ccpp-physics
* Update submodule pointer for ccpp-physics - MYNN surface layer updates and bugfixes (#63)
* Land stochastic perturbations (wrapper PR for #65) (#68)
* Move initialization of stochastic physics after the physics
initialization in CCPP.
* Add albedo variables to land perturbations with lndp_type=2 option. Change to accommodate soil perturbations with RUC LSM.
* Max/min soil moisture variables are introduced via GFS_Control_type
variables instead of through the use of namelist_soilveg*. This is a
more flexible way for different LSMs.
* Added pores and resid variables for max/min soil moisture to GFS_typedefs.f90.
* Remove tracer_sanitizer from all suites and from CCPP prebuild config
* Add namelist option to apply land surface perturbations at every time step, clean up stochastic_physics/stochastic_physics_wrapper.F90
* Stochastic land perturbations: add roughness length over land to the perturbed variables (#70)
* Added roughness length over land to the perturbed variables.
* Bugfix in gfsphysics/GFS_layer/GFS_typedefs.F90: remove Diag%cldcov, in particular the reset call because the variable is not allocated
* Update .gitmodules and submodule pointer for GFDL_atmos_cubed_sphere for code review and testing
* Revert change to .gitmodules for ccpp-physics, update submodule pointer for ccpp-physics
* Revert change to .gitmodules and update submodule pointer for GFDL_atmos_cubed_sphere
Co-authored-by: DomHeinzeller <[email protected]>
Co-authored-by: Phil Pegion <[email protected]>
Co-authored-by: shansun6 <[email protected]>
Co-authored-by: tanyasmirnova <[email protected]>

* Dycore change to add an option to zero-gradient BC for height advection and change dz_min as a namelist input (#232)

* Point dycore to a personal branch
* Point to new version of dycore
* Update the dycore version
* Update the dycore version
* Point to NOAA-EMC dev/emc dycore branch

* Remove gnumake build remnants, change v16beta to v16 (#234)

* Remove gnumake files
* Replace v16beta with v16 for all CCPP suites
* Remove unused CCPP_INCLUDE_DIRS/CCPP_LIB_DIRS from ccpp/CMakeLists.txt

* Move LSM vegetation lookup tables into CCPP, clean up RUC snow cover on ice initialization  (remove IPD step 2) (#244)

* Move LSM vegetation lookup tables into CCPP, clean up RUC snow cover on ice initialization
* Revert change to .gitmodules and update submodule pointer for ccpp-physics

* UGWP v0 v1 combined (#241)

* .gitmodules/gsl atmos-cubed cccp-fram cccp/physics
* update fv3atm from NOAA-EMC Jan 9
* new suite_FV3_GFS_v16b_ugwpv1.xml and modifications Jan 11/2021
* Added new logical flag do_ugwp_v0_nst_only which allows non-stationary drag from ugwp_v0 to be run with GSL drag suite
* Fix formatting in ccpp/data/GFS_typedefs.*
* Clean up allocation of arrays in ccpp/data/GFS_typedefs.F90, add active attribute (pass 1) to ccpp/data/GFS_typedefs.meta, strip trailing whitespaces from both
* Update and cleanup of metadata for UGWPv0, UGWPv1, drag suite
* Reorganize UGWP diagnostic variables in data/GFS_typedefs.{F90,meta}
* Bugfix for uninitialized data in ccpp/data/GFS_typedefs.F90
* Update submodule pointer for ccpp-physics
* Allocate 3d diagnostic arrays as dummy arrays if not used

Co-authored-by: valery.yudin <[email protected]>
Co-authored-by: Michael Toy <[email protected]>

* SDF for GFSv16 with Thompson (#238)

* SDF for GFSv16 with Thompson
* Delete suite_FV3_GFS_v16beta_thompson.xml
* update to new commit of Thompson MP in ccpp physics

Co-authored-by: Phil Pegion <[email protected]>
Co-authored-by: shansun6 <[email protected]>
Co-authored-by: Mark Potts <[email protected]>
Co-authored-by: Shrinivas.Moorthi <[email protected]>
Co-authored-by: dustinswales <[email protected]>
Co-authored-by: Jun Wang <[email protected]>
Co-authored-by: XiaqiongZhou-NOAA <[email protected]>
Co-authored-by: valery.yudin <[email protected]>
Co-authored-by: Michael Toy <[email protected]>
Co-authored-by: XiaSun-NOAA <[email protected]>

* Remove inconsistencies in computation of air density with Thompson MP (#74)

* Update .gitmodules and submodule pointer for ccpp-physics for code review and testing

* Revert change to .gitmodules and update submodule pointer for ccpp-physics

* Update thompson mp 20210213 (#567) for gsl/develop (#75)

* Add logical convert_dry_rho for Thompson MP, hardcoded to false
* Initialize all variables to NaN in ccpp-physics in DEBUG mode
* Update submodule pointer for ccpp-physics

* Revert change to .gitmodules and update submodule pointer for ccpp-framework and ccpp-physics

* &gfs_physics_nml print_diff_pgr=.true. will print per-timestep pgr change stats

* point to sam's repository for atmos_cubed_sphere

* Add units and lat/lon to per-timestep pgr stats

* Rebase atmos_cubed_sphere to NOAA-GFDL dev/emc branch

* Print mean pgr change as hPa/hr and other pgr data as bars.

* Remove changes from atmos_cubed_sphere and simplify atmos_model.F90 changes.

* print mean abs change instead of mean change in pgr

* Update .gitmodules and submodule pointers for ccpp-framework and ccpp-physics for code review and testing

* Revert change to .gitmodules and update submodule pointers for ccpp-framework and ccpp-physics

* clarify one print

* More 3D diagnostic tendencies (#76)

Add diagnostic tendencies for all tracers. Move all d*3dt variables into a 4D sparse array stored as `dtend(i,k,dtidx(tracer,process))` to reduce memory usage.

* Fix incorrect units in dtend metadata (#82)

* Fix incorrect units in dtend metadata

* Make the tracer tendency units mandatory.

* Add SO2 tendency units (#86)

* Update .gitmodules and submodule pointers for ccpp-framework and ccpp-physics

* Update submodule pointer for ccpp-physics

* Revert change to .gitmodules and update submodule pointer for ccpp-framework and ccpp-physics

* dtend: add missing tendencies and fix bugs in convection tendencies (#92)

* Fix incorrect units in dtend metadata

* Point to corresponding ccpp/physics branch

* fixes to dtend support:

1. Store rtg (AKA clw AKA qtr) instead of gq0 in DCNV and SCNV
pre/post for schemes that use convective transport. Tracers handled
solely by convective transport (ones not in rtg) are reported as
convective transport tendencies. Tendencies for variables in rtg are
reported as dcnv and scnv tendencies.

2. Report TKE tendencies from gfs v16 PBL.

3. Add diagnostic tendencies to drag_suite

4. Only report rayleigh damping tendencies if rayleigh damping is enabled

5. List all possible diagnostic tendencies, even if they are not
enabled. In the output, label them "selected" or "disabled."

6. Add phys_tend to the fv3_rap suite.

* Merge gsl/develop into ccpp/physics

* Add phys_tend to suite_FV3_GSD_SAR and remove some debug prints

* Remove some debug prints and commented-out code.

* Correct error in dtend variable availability list print.

* Enable convtrans diagnostic tendencies for number concentrations and qrimef.

* Disable cnvtrans diagnostic tendencies for schemes that do their own diagnostic tendency reporting.

* Point to gsl repositories

* Update .gitmodules for code review and regression testing

* Formatting changes in ccpp/data/GFS_typedefs.F90

* Update submodule pointer for ccpp-physics

* Update submodule pointer for ccpp-physics

* Point update_gsl_develop_from_develop_20210531 to NOAA-GSL branches of ccpp/physics and ccpp/framework

* GF aerosols updates and tunings

* GF aerosol updates and tunings from physics

* Update .gitmodules and submodule pointer for ccpp-physics for code review and testing

* Update submodule pointer for ccpp-physics

* Update submodule pointer for ccpp-physics

* Update submodule pointer for ccpp-physics

* Make aod_gf and cactiv_m work appriopriately for restarts
Minor code cleanup

* Add missing metadata for new GF arrays

* Bug fix in ccpp/driver/GFS_restart.F90 for GF

* Update submodule pointer for ccpp-physics

* Revert change to .gitmodules and update submodule pointer for ccpp-physics

* Add missing active attribute for aod_gf in ccpp/data/GFS_typedefs.meta

* Update submodule pointer for ccpp-physics

* Update submodule pointer for ccpp-physocs

* Change name of sfc_name2(39) from 'weasd' to 'weasdl' in io/FV3GFS_io.F90

* Revert change to .gitmodules and update submodule pointers for ccpp-framework and ccpp-physics

* Update .gitmodules and submodule pointer for ccpp-physics for code review and testing

* Update .gitmodules and submodule pointer for ccpp-physics for code review and testing

* Revert change to .gitmodules and update submodule pointer for ccpp-physics

* Changed dimensions of variables tsnow_land and sncovr_ice from
horizontal_dimension to horizontal_loop_extent

* Added Flake to two suites: FV3_GSD_v0 and FV3_HRRR.

* Update .gitmodules and submodule pointer for ccpp-physics for code review and testing

* Update submodule pointer for ccpp-physics

* Revert change to .gitmodules and update submodule pointer for ccpp-physics

* Update to ccpp/data/GFS_typedefs.meta following CCPP standard names update

* Update submodule pointer for ccpp-physics

* Revert change to .gitmodules and update submodule pointer for ccpp-physics

* Revert change to .gitmodules and update submodule pointers for ccpp-physics and ccpp-framework

* Revert change to .gitmodules and update submodule pointers for ccpp-framework and ccpp-physics

* Turn on GF aerosol-awareness
Tune clwdet (cloud water detrainment)
Make evfact (evaporation factor) and radiation factor scale-aware

* Update .gitmodules and submodule pointers for ccpp-framework and ccpp-physics for code review and testing

* Switch back to NCAR ccpp-framework main, abandon NOAA-GSL fork

* Update submodule pointer for ccpp-physics

* Update submodule pointer for ccpp/physics

* Update .gitmodules and submodule pointer for ccpp-physics for code review and testing

* Update submodule pointer for ccpp-physics

* Revert change to .gitmodules and update submodule pointer for ccpp-physics

* Update submodule pointer for ccpp-physics

* Revert change to .gitmodules and update submodule pointer for ccpp-physics

* Update .gitmodules and submodule pointer for ccpp-physics for code review aand testing

* Update submodule pointer for ccpp-physics

* Revert change to .gitmodules and update submodule pointer for ccpp-physics

* Update .gitmodules and submodule pointer for ccpp-physics for code review and testing

* Update submodule pointer for ccpp-physics

* Revert .gitmodules and update submodule pointer for ccpp-physics

* Revert change to .gitmodules and update submodule pointer for ccpp-physics

* Update .gitmodules and submodule pointer for ccpp-physics for code review and testing

* Revert .gitmodules and update submodule pointer for ccpp-physics

* Update CCPP metadata and several suite defiition files for new GSL regression tests

* Bug fix for compiling with Intel on macOS, remove clutter from stdout in io/FV3GFS_io.F90

* Update .gitmodules and submodule pointer for ccpp-physics for code review and testing

* Rename GSL suites to RAP suites, add new RAP suites

* rename suite FV3_GSD_v0 to FV3_RAP_noah_sfcdiff_cires_ugwp, delete suite FV3_SAR

* Update submodule pointer for ccpp-physics

* Address reviewer comments

* Update submodule pointer for ccpp-physics

* Revert .gitmodules and update submodule pointer for ccpp-physics

Co-authored-by: DomHeinzeller <[email protected]>
Co-authored-by: Phil Pegion <[email protected]>
Co-authored-by: shansun6 <[email protected]>
Co-authored-by: tanyasmirnova <[email protected]>
Co-authored-by: tanyasmirnova <[email protected]>
Co-authored-by: Mark Potts <[email protected]>
Co-authored-by: Shrinivas.Moorthi <[email protected]>
Co-authored-by: dustinswales <[email protected]>
Co-authored-by: Jun Wang <[email protected]>
Co-authored-by: XiaqiongZhou-NOAA <[email protected]>
Co-authored-by: valery.yudin <[email protected]>
Co-authored-by: Michael Toy <[email protected]>
Co-authored-by: XiaSun-NOAA <[email protected]>
Co-authored-by: samuel.trahan <[email protected]>
Co-authored-by: Samuel Trahan (NOAA contractor) <[email protected]>
Co-authored-by: hannah barnes <[email protected]>
Co-authored-by: Hannah C Barnes <[email protected]>
DusanJovic-NOAA pushed a commit to DusanJovic-NOAA/fv3atm that referenced this pull request Mar 10, 2022
@mzhangw @climbfuji
Merge mzhangw:HAFS_FER_hires into NCAR:dtc/hwrf-physics
fbfc0c0 
Squashed commit of the following:

commit a77f292f7eab4f6e5f24dc3af5f8a71fe4cf9347
Merge: 070386e0 722339d1
Author: Man.Zhang <[email protected]>
Date:   Mon Mar 16 10:30:11 2020 -0600

    Merge branch 'dtc/develop' of https://github.com/NCAR/fv3atm into HAFS_fer_hires

commit 070386e0d18762d57483fa699408f2265d2e3887
Author: Man.Zhang <[email protected]>
Date:   Mon Mar 16 10:00:33 2020 -0600

    delete optional vars related to FA scheme

commit 722339d1cfa75cc63dedde486c733f3907a716ac
Merge: e88f2b37 fcb13133
Author: Dom Heinzeller <[email protected]>
Date:   Fri Mar 13 13:05:52 2020 -0600

    Merge pull request #30 from climbfuji/update_from_dev_emc_20200312_and_other_changes

    Update from emc/develop 2020/03/12 and other changes

commit fcb131337e5d0091440db93ce004b2339b3ccc3d
Author: Dom Heinzeller <[email protected]>
Date:   Fri Mar 13 13:04:05 2020 -0600

    Revert change to .gitmodules, update submodule pointers for GFDL_atmos_cubed_sphere and ccpp-physics

commit 872b8fc90354ab4c84be14ae310865aa323bca5a
Author: Dom Heinzeller <[email protected]>
Date:   Thu Mar 12 20:57:19 2020 -0600

    gfsphysics/GFS_layer/GFS_typedefs.F90: bugfix for declaration of variable radar_reset

commit 1b5bd6e55c038f01a8e8e39ce0fae330ab4be850
Author: Dom Heinzeller <[email protected]>
Date:   Thu Mar 12 13:38:50 2020 -0600

    Update .gitmodules for code review and testing

commit 67c8b06418730d2672b68562dc111c0b48271822
Author: Dom Heinzeller <[email protected]>
Date:   Thu Mar 12 13:13:57 2020 -0600

    Add nsradar_reset to control resetting radar calculations for Thompson MP

commit 6d3399bf8fa0942e5524321ac7e22b7091c7d36b
Merge: 4e545798 e88f2b37
Author: Dom Heinzeller <[email protected]>
Date:   Thu Mar 12 13:13:12 2020 -0600

    Merge branch 'dtc/develop' of https://github.com/NCAR/fv3atm into update_from_dev_emc_20200312_and_other_changes

commit e88f2b37b4607b739448a8c82c50f825529ecf9c
Merge: 1a385e35 cc085c72
Author: Dom Heinzeller <[email protected]>
Date:   Thu Mar 12 13:08:46 2020 -0600

    Merge pull request #29 from climbfuji/merge_emc_develop_20200311_after_moorthi_before_dycore_pr7

    dtc/develop: merge emc/develop 2020/03/11 (after Moorthi's commit, before dycore OMP bugfix)

commit cc085c7244a810cdeeed0f41f3bffccba2fdc6bb
Author: Dom Heinzeller <[email protected]>
Date:   Thu Mar 12 13:07:54 2020 -0600

    Revert change .gitmodules and update submodule pointer for ccpp/physics

commit d97b557dbe46343a66835467e9cd82aa33dc936a
Author: Man.Zhang <[email protected]>
Date:   Thu Mar 12 11:06:17 2020 -0600

    add  optional vars in FA to prebuild script

commit 4e5457980b817588c185f457d714d9ce9d162225
Merge: 2de5048f fc9a4c21
Author: Dom Heinzeller <[email protected]>
Date:   Thu Mar 12 10:39:17 2020 -0600

    Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into merge_emc_develop_20200311_after_moorthi_before_dycore_pr7

commit 2de5048fe31645d7773aa643aef77653b694a426
Author: Dom Heinzeller <[email protected]>
Date:   Thu Mar 12 08:46:13 2020 -0600

    Update .gitmodules for code review

commit 250704553bbfce541a76e53d33614eac6b3ecf49
Author: Dom Heinzeller <[email protected]>
Date:   Thu Mar 12 08:37:02 2020 -0600

    Add moninedmf_hafs.f to CCPP prebuild config

commit 3375ede9c7a567e37e1db01a22b2ba41bf701d7a
Merge: 1a385e35 38a495ee
Author: Dom Heinzeller <[email protected]>
Date:   Wed Mar 11 10:25:31 2020 -0600

    Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into HEAD

commit 793719b602a9bfdd14d599e5163c152bee0b250d
Merge: 0a0d3344 1a385e35
Author: Man.Zhang <[email protected]>
Date:   Wed Mar 11 10:20:02 2020 -0600

    Merge branch 'dtc/develop' of https://github.com/NCAR/fv3atm into HAFS_fer_hires

commit 1a385e35988e34035010931af9d8229ae5cabd83
Merge: 756ef51a c6e17ef0
Author: Dom Heinzeller <[email protected]>
Date:   Mon Mar 9 12:43:32 2020 -0600

    Merge pull request #27 from climbfuji/update_dtc_develop_from_emc

    Update dtc/develop from emc/develop 2020/03/04

commit c6e17ef0f904f896dee6aceda6de57126c48f675
Author: Dom Heinzeller <[email protected]>
Date:   Mon Mar 9 12:42:42 2020 -0600

    Revert change to .gitmodules, update submodule pointer for atmos_cubed_sphere

commit 0a0d334483ef2f0f368f8e0e3767b0ca30de09e4
Merge: 3908b386 756ef51a
Author: Man.Zhang <[email protected]>
Date:   Sun Mar 8 10:21:03 2020 -0600

    Merge branch 'dtc/develop' of https://github.com/NCAR/fv3atm into HAFS_fer_hires

commit bf5bfa1957d3684f3372f93a1cc3ac3a63a6d923
Author: Dom Heinzeller <[email protected]>
Date:   Wed Mar 4 09:34:36 2020 -0700

    Update submodule pointer for .gitmodules for code review and testing

commit 5c6bd37e09b586fa1ae3e34c5d6b27b68858c7b9
Merge: 756ef51a 8683a693
Author: Dom Heinzeller <[email protected]>
Date:   Fri Feb 28 08:49:20 2020 -0700

    Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into HEAD

commit 756ef51a99efefac0db3f9fe53da207ca9306ee1
Merge: 9de2a9da cf0fad6c
Author: Dom Heinzeller <[email protected]>
Date:   Thu Feb 6 13:37:01 2020 -0700

    Merge pull request #25 from climbfuji/dom_combine_prs_20200204

    dtc/develop: combined PRs for ccpp-framework and ccpp-physics

commit cf0fad6c59325201c6a345087ff4cf6793a30c94
Author: Dom Heinzeller <[email protected]>
Date:   Thu Feb 6 13:33:19 2020 -0700

    Revert change to .gitmodules, update submodule pointers for ccpp-framework and ccpp-physics

commit b2614a4d853e100a9f454d29c2f37d309687ca0e
Author: Dom Heinzeller <[email protected]>
Date:   Tue Feb 4 17:19:51 2020 -0700

    Update .gitmodules and submodule pointers for code review and testing

commit 9de2a9da7b6a16154c6f1908b16948692166aa69
Merge: e14e81fd 35bbaf70
Author: Dom Heinzeller <[email protected]>
Date:   Mon Feb 3 07:48:46 2020 -0700

    Merge pull request #24 from climbfuji/update_dtc_develop_from_develop

    dtc/develop: update from develop 2020/01/27

commit 35bbaf70594198671c67040a20c4aefcd36ccdbe
Author: Dom Heinzeller <[email protected]>
Date:   Mon Feb 3 07:45:43 2020 -0700

    Revert .gitmodules change, update submodule pointers

commit 92341280c61724c8eada0dcb87136ed1478e501b
Author: Dom Heinzeller <[email protected]>
Date:   Mon Jan 27 09:42:55 2020 -0700

    Update .gitmodules for code review and testing

commit 77e0957f64380e07a87856982ec78430e56e6cb9
Merge: e14e81fd 7ffe6471
Author: Dom Heinzeller <[email protected]>
Date:   Mon Jan 27 09:41:52 2020 -0700

    Merge branch 'develop' of https://github.com/noaa-emc/fv3atm into HEAD

commit e14e81fd2cab47ab993eb8f4bd9dfc07c74e5654
Merge: 6353b7c7 fa72e2b0
Author: Dom Heinzeller <[email protected]>
Date:   Thu Dec 26 07:59:59 2019 -0700

    Merge pull request #22 from climbfuji/sar_fix_hrrr_ics

    Bug fix in io/FV3GFS_io.F90 for RUC LSM with RAP/HRRR initial data

commit fa72e2b054d4d383a2c482cf5fc9a1f27f850e71
Author: Dom Heinzeller <[email protected]>
Date:   Mon Dec 23 14:35:24 2019 -0700

    io/FV3GFS_io.F90: bugfix for cold starts from RAP/HRRR initial conditions

commit 3908b386801502de7727b9c0aaa918e3f652742a
Merge: fc1bc3d5 6353b7c7
Author: Man.Zhang <[email protected]>
Date:   Thu Dec 19 09:45:40 2019 -0700

    Merge branch 'dtc/develop' of https://github.com/NCAR/fv3atm into HAFS_fer_hires

commit 6353b7c75e6b6c90371caf5ef542eb2e20ef3e8e
Merge: 153ae61d 9228d4ca
Author: Dom Heinzeller <[email protected]>
Date:   Tue Dec 17 15:46:15 2019 -0700

    Merge pull request #21 from climbfuji/update_dtc_develop_from_ufs_public_release_20191216

    Update dtc develop from EMC develop and ufs_public_release 2019/12/16

commit 9228d4ca4bcd8bf9022d23739c4f1248c1955c8b
Author: Dom Heinzeller <[email protected]>
Date:   Mon Dec 16 07:19:22 2019 -0700

    Updates from ufs_public_release: use correct NETCDF variable for new cmake build, rename suite FV3_GFS_v15.2 to FV3_GFS_v15p2

commit d0a75a94739c8287f667e1c728964824f540fcea
Merge: 52642725 8a567812
Author: Dom Heinzeller <[email protected]>
Date:   Sat Dec 14 07:07:47 2019 -0700

    Merge branch 'develop' of https://github.com/noaa-emc/fv3atm into HEAD

commit 153ae61d6227cda619d56a53832fadf5a54d1384
Merge: 52642725 38b88348
Author: Dom Heinzeller <[email protected]>
Date:   Thu Dec 12 09:36:17 2019 -0700

    Merge pull request #20 from grantfirl/fix_GFS_v15p2_name

    change suite_FV3_GFS_v15.2 to suite_FV3_GFS_v15p2

commit 38b88348105a4ccbbdefe763411ba0e52b3740b6
Author: Grant Firl <[email protected]>
Date:   Thu Dec 12 09:33:33 2019 -0700

    change suite_FV3_GFS_v15.2 to suite_FV3_GFS_v15p2

commit fc1bc3d5f47de906737576fb20284e2859d59581
Merge: ad49383c 52642725
Author: Man.Zhang <[email protected]>
Date:   Wed Dec 11 12:58:05 2019 -0700

    Merge branch 'dtc/develop' of https://github.com/NCAR/fv3atm into HAFS_fer_hires

commit 52642725bf69213c9766846b470f1812076d3541
Merge: 88e87e9b fd8b1d6a
Author: Dom Heinzeller <[email protected]>
Date:   Mon Dec 9 11:04:33 2019 -0700

    Merge pull request #15 from climbfuji/update_dtc_develop_from_emc_develop_and_collect_updates_20191205

    Update dtc/develop from EMC develop and collect updates 2019/12/05

commit fd8b1d6aefe552ad2d5d1fff8a443f4e8f04269c
Author: Dom Heinzeller <[email protected]>
Date:   Mon Dec 9 11:04:03 2019 -0700

    Update submodule pointer for ccpp/physics

commit 1c7f2c1d0319cd4cbb14aef4dcb6cff2019ad09e
Merge: 37800303 718b7a50
Author: Dom Heinzeller <[email protected]>
Date:   Fri Dec 6 12:51:13 2019 -0700

    Merge branch 'fix_cires_ugwp_dimension_bug' of https://github.com/grantfirl/fv3atm into update_dtc_develop_from_emc_develop_and_collect_updates_20191205

commit 718b7a5086ae259cbff2f53dbed7913e67a60377
Author: Grant Firl <[email protected]>
Date:   Fri Dec 6 12:45:15 2019 -0700

    fix cires_ugwp_init call arguments in GFS_driver.F90 (there is no issue in CCPP version)

commit 378003032b675a797c787eb0091f2e49eea78d43
Merge: b317eae9 aa99bea5
Author: Dom Heinzeller <[email protected]>
Date:   Fri Dec 6 11:03:40 2019 -0700

    Merge branch 'fix_cires_ugwp_dimension_bug' of https://github.com/grantfirl/fv3atm into update_dtc_develop_from_emc_develop_and_collect_updates_20191205

commit b317eae93c5ec204113a0d9ef18de1fba85db543
Author: Dom Heinzeller <[email protected]>
Date:   Fri Dec 6 10:59:40 2019 -0700

    Bugfixes for NoahMP precipitation rate PR

commit aa99bea5af49f2ca0ecb38114d4adc455f4c75e8
Author: Grant Firl <[email protected]>
Date:   Fri Dec 6 10:30:13 2019 -0700

    fix array dimensions for phii, prsi in ugwp_driver_v0.F

commit 3be9f9899755379311b64181ca2df9a3bace4b2f
Merge: 41884c2b d373518c
Author: Dom Heinzeller <[email protected]>
Date:   Fri Dec 6 07:48:36 2019 -0700

    Merge branch 'dtc/develop' of https://github.com/panll/fv3atm into update_dtc_develop_from_emc_develop_and_collect_updates_20191205

commit 41884c2b3226c755bb56b4a94d2be0db0afde13b
Merge: 0a292c4e eb4c2e05
Author: Dom Heinzeller <[email protected]>
Date:   Fri Dec 6 07:44:01 2019 -0700

    Merge branch 'fix_noahmp_precip_rates' of https://github.com/grantfirl/fv3atm into update_dtc_develop_from_emc_develop_and_collect_updates_20191205

commit eb4c2e05ef06e464b9ce46d924d6dee58b7f6a10
Author: Grant Firl <[email protected]>
Date:   Thu Dec 5 22:18:03 2019 -0700

    make associated change to GFS_physics_driver for NoahMP precip rates

commit d373518cb7fbf196411bd13df020d19ca79d50ca
Author: Linlin.Pan <[email protected]>
Date:   Fri Dec 6 00:11:30 2019 +0000

    adding new suit files for GFS v15.2 and GFS v16beta

commit 9f728649a3344ebfdd93f4701b54f6f83a027bce
Author: Linlin.Pan <[email protected]>
Date:   Fri Dec 6 00:00:34 2019 +0000

    update the suite file for coupling
    removing <scheme>samfshalcnv_post</scheme>
    adding  <scheme>GFS_GWD_generic_post</scheme>

commit 0a292c4e7ad7e40ae5216a6248ae658b0336fb9d
Merge: 88e87e9b 26de321b
Author: Dom Heinzeller <[email protected]>
Date:   Thu Dec 5 15:40:02 2019 -0700

    Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into HEAD

commit ad49383c19fa17abc16598dee755b178fffb98bf
Merge: 78e06cb2 88e87e9b
Author: Man.Zhang <[email protected]>
Date:   Thu Dec 5 13:10:26 2019 -0700

    Merge branch 'dtc/develop' of https://github.com/NCAR/fv3atm into HAFS_fer_hires

commit c9322aa19776e69ba18b116739dee07425989df1
Author: Grant Firl <[email protected]>
Date:   Thu Dec 5 13:06:51 2019 -0700

    change RUC surface precip vars to Sfcprop DDT in GFS_restart.F90

commit 66c70012a2eea36fcece6b812b32f891d9163ff8
Author: Grant Firl <[email protected]>
Date:   Thu Dec 5 12:58:37 2019 -0700

    remove sfc_noahmp_pre interstitial scheme from prebuild and SDF, move precip variables needed by LSMs from TBD DDT to Sfcprop DDT

commit 3aacc00f36c90ab2997c6203e1862a5fe0b4a7e7
Author: Linlin.Pan <[email protected]>
Date:   Wed Dec 4 20:23:59 2019 +0000

    changing ccpp/suites/suite_FV3_GFS_2017_couple.xml
    to ccpp/suites/suite_FV3_GFS_2017_coupled.xml

commit 88e87e9bd063d8d02fd7830db77a623b6533bb9a
Merge: bc316893 eae67862
Author: Dom Heinzeller <[email protected]>
Date:   Tue Dec 3 15:22:43 2019 -0700

    Merge pull request #11 from climbfuji/dtc_develop_udpate_from_emc_20191127

    dtc/develop: update from EMC 2019/11/27

commit eae67862e08a1285d4e2029aa8312f6d6d3ec7d8
Author: Dom Heinzeller <[email protected]>
Date:   Tue Dec 3 15:22:19 2019 -0700

    Update submodule pointers for atmos_cubed_sphere, ccpp/framework, ccpp/physics

commit 8b23f662cdc9eccb2bc4ddf31f3b7baebfb19c0c
Author: Linlin.Pan <[email protected]>
Date:   Tue Dec 3 16:35:55 2019 +0000

    adding updated suite for coupling
     ccpp/suites/suite_FV3_GFS_2017_couple.xml

commit 2de4377fddeaf2c8d58202e8fef54274b313092c
Author: Dom Heinzeller <[email protected]>
Date:   Mon Dec 2 11:02:38 2019 -0700

    Update submodule pointers for ccpp-framework and ccpp-physics

commit ac71e234cbecf8e7b516e6fafc7872d1bf45b009
Author: Dom Heinzeller <[email protected]>
Date:   Fri Nov 29 17:03:49 2019 -0700

    ccpp/CMakeLists.txt: add flag '-Wall' to DEBUG flags for GNU compiler

commit 9caa172aaf8757dadc2590d2599706e00225bf51
Author: Dom Heinzeller <[email protected]>
Date:   Wed Nov 27 14:33:32 2019 -0700

    Update submodule pointer for ccpp/physics

commit 03f7d7815cd4b2ed4d2226be64dcef22b6a06d44
Merge: bc316893 ea91f650
Author: Dom Heinzeller <[email protected]>
Date:   Wed Nov 27 14:26:39 2019 -0700

    Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into HEAD

commit bc316893a123a9437642497f417fa2217491efdb
Merge: cb7e3891 661e98c2
Author: Dom Heinzeller <[email protected]>
Date:   Wed Nov 27 13:42:34 2019 -0700

    Merge pull request #10 from climbfuji/merge_gsd_develop_and_update_basedir_builddir_logic

    dtc/develop: merge gsd/develop, update CCPP prebuild config

commit 661e98c2833876e1de26989bb470fdf73730415e
Author: Dom Heinzeller <[email protected]>
Date:   Wed Nov 27 13:41:25 2019 -0700

    Update submodule pointers for ccpp/framework and ccpp/physics

commit 07af073d0260e203433e96720e8572ce688e0697
Author: Dom Heinzeller <[email protected]>
Date:   Tue Nov 26 11:58:13 2019 -0700

    Update submodule pointers for ccpp-framework and ccpp-physics

commit 1688b2990cde67a4637b34a9b9628296db0314e5
Author: Dom Heinzeller <[email protected]>
Date:   Tue Nov 26 11:57:51 2019 -0700

    ccpp/config/ccpp_prebuild_config.py: add new configuration item DEFAULT_BUILD_DIR

commit a550ddf96f6052fad2d1d002a58dec2c2fff7277
Author: Dom Heinzeller <[email protected]>
Date:   Tue Nov 26 08:42:25 2019 -0700

    Merge FV3 gsd/develop into fv3atm dtc/develop, squashed commit of the following:

    commit 7eed7477b120e9298312f6ea64739052351f288e
    Merge: a3043d1 1876fb5
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Nov 21 15:40:23 2019 -0700

        Merge pull request #220 from tanyasmirnova/ruc_land_ice_v1

        Added the capability to initialize Leaf Area Index (LAI) from the cli…

    commit 1876fb523f54092c729f61d72ab296f85482a3c4
    Author: tanyasmirnova <[email protected]>
    Date:   Wed Nov 20 23:47:09 2019 +0000

        Remove a factor of 100 from LAI output.

    commit cbea4199943dc124bdd4f7ac7b04fe2e136c55b7
    Author: tanyasmirnova <[email protected]>
    Date:   Wed Nov 20 23:38:14 2019 +0000

        This commits adds LAI to the history output.

    commit f7a4ee4d3bc7a011c22118d32fabaa7035b4df1d
    Author: tanyasmirnova <[email protected]>
    Date:   Wed Nov 20 20:23:40 2019 +0000

        Added the capability to initialize Leaf Area Index (LAI) from the climatological information.
        This capability is controlled by the new namelist parameter - rdlai, which is added to the
        GFS_typedefs.meta. When rdlai=.false., no changes to the input, but if rdlai=.true., then a
        new variable should be available in sfc_data.nc input, and it will be read in into the xlaixy variable.

    commit a3043d1bc1391cedd816f851785de57bf4dcc1b2
    Merge: 179cbe7 57d937b
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Sep 24 12:56:30 2019 -0600

        Merge pull request #210 from climbfuji/update_gsd_develop_from_gmtb_develop_20190924

        Update gsd/develop from gmtb/develop 2019/09/24

    commit 57d937b8669b5404313f3b2b1c270fdcf532cd1a
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Sep 24 12:36:46 2019 -0600

        Update CODEOWNERS and submodule atmos_cubed_sphere for gsd/develop

    commit d7699bab4b20211db4a8ca3988e3ee8a744ab46f
    Merge: 86ad37a fadbbda
    Author: Dom Heinzeller <[email protected]>
    Date:   Mon Sep 23 10:13:22 2019 -0600

        Merge pull request #209 from climbfuji/update_submodule_pointer_atmos_cubed_sphere_20190923

        Update submodule pointer for atmos_cubed_sphere 2019/09/23

    commit fadbbda009dfccf66cecf814bf1c5475329e1a71
    Author: Dom Heinzeller <[email protected]>
    Date:   Mon Sep 23 10:11:18 2019 -0600

        Update submodule pointer for atmos_cubed_sphere

    commit 86ad37a15dbd7e99f732c80cb758fad541535326
    Merge: d02e260 ef0469f
    Author: Dom Heinzeller <[email protected]>
    Date:   Mon Sep 23 09:33:13 2019 -0600

        Merge pull request #207 from climbfuji/gmtb_develop_update_from_master_20190920

        gmtb/develop update from master 2019/09/20, remove TRANSITION mode

    commit ef0469fcb5345d472324720e3c0043b65507c0bd
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Sep 20 08:53:31 2019 -0600

        Remove TRANSITION mode

    commit 65bfa600345eed605ac580fd35c984c1d915d405
    Merge: 545a5ab b67d9a3
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Sep 20 07:23:01 2019 -0600

        Merge branch 'master' of gerrit:FV3 into gmtb_develop_update_from_master_20190920

    commit 545a5ab4fb70f5c7e9164107fb6f77d5ea94128e
    Merge: d02e260 42915ea
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Sep 20 06:59:23 2019 -0600

        Merge branch 'master' of https://github.com/NCAR/FV3 into HEAD

    commit d02e260c161addf0bc6589b8f91a6098c4cd57ab
    Merge: 9ad9373 fd8f98a
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Sep 19 14:40:14 2019 -0600

        Merge pull request #206 from climbfuji/myj_with_dom_mods

        gmtb/develop: MYJ PBL/SFC, Noah MP

    commit fd8f98a43258d9f593fff11f14c4216fca484cfd
    Author: Dom Heinzeller <[email protected]>
    Date:   Mon Sep 16 15:30:40 2019 -0600

        gfsphysics/GFS_layer/GFS_driver.F90, gfsphysics/makefile, io/FV3GFS_io.F90: re-enable calculation of snocvr in FV3-IPD to avoid b4b issues when 32BIT=Y

    commit daab7457cf08c205c5016c8ec7865fbb08b8495f
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Sep 13 16:29:43 2019 -0600

        gfsphysics/GFS_layer/GFS_typedefs.{F90,meta}: introduce lower bound variable for snow-related arrays in NoahMP, use in metadata table

    commit 243977dd91ea022a76dd799f5810357117af13ad
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Sep 13 16:28:01 2019 -0600

        gfsphysics/GFS_layer/GFS_driver.F90: update comment on CCPP code

    commit 03b00f445c72e1617bef13971cf2b5dd2c4e412f
    Merge: 1bb9ab5 c83f1f7
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Sep 13 15:28:19 2019 -0600

        Merge branch 'noahmp' of https://github.com/grantfirl/FV3 into myj_with_dom_mods

    commit 1bb9ab5097d9906db571d4b4f40211646e23b3a2
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Sep 13 15:28:16 2019 -0600

        gfsphysics/GFS_layer/GFS_typedefs.F90: remove empty line

    commit 1627b2359bc490d4cce58a47ffccbc1c27a61ad9
    Merge: 7da9ed8 9ad9373
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Sep 13 15:00:37 2019 -0600

        Merge branch 'gmtb/develop' of https://github.com/NCAR/FV3 into myj_with_dom_mods

    commit 9ad93730b81314d1ffaf0b98cd81e7d442ccf874
    Merge: 1fa34bc 4354488
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Sep 13 15:00:08 2019 -0600

        Merge pull request #204 from climbfuji/correct_longnames_20190909

        gmtb/develop: correct long names, align with SCM

    commit 7da9ed859921d2ffe1ffdcf6f17ae2ae58449050
    Merge: 4354488 bcfed5b
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Sep 13 10:49:16 2019 -0600

        Merge branch 'myj_from_qingfu' into correct_longnames_20190909

    commit 43544887d2b6624606dc82f30e4854dc49f23d20
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Sep 12 21:11:20 2019 -0600

        gfsphysics/GFS_layer/GFS_typedefs.meta: correct longnames and align with SCM

    commit c83f1f738b60772b2ae4dff6f6e2434ccc42bc04
    Author: Grant Firl <[email protected]>
    Date:   Tue Sep 10 17:37:42 2019 -0600

        update comments in GFS_physics_driver.F90 for locations of NoahMP-related code

    commit b4a674d9ae4144f25261943bf8a4481d09debe96
    Merge: 36ab5be 1fa34bc
    Author: Grant Firl <[email protected]>
    Date:   Tue Sep 10 17:26:13 2019 -0600

        Merge branch 'gmtb/develop' into noahmp

    commit 1fa34bc41fe59e9efbb12aeab474c83bf7670420
    Merge: 028a54e 67db064
    Author: Dom Heinzeller <[email protected]>
    Date:   Sun Sep 8 20:32:08 2019 -0600

        Merge pull request #203 from climbfuji/gmtb_develop_monster_merge_20190904

        Merge gsd/develop, update from Vlab, separate stochastic physics from IPD and CCPP

    commit 36ab5be04ffa4e0aabbe7cdae36c378881513739
    Author: Grant Firl <[email protected]>
    Date:   Fri Sep 6 15:15:24 2019 -0600

        change location of interstitial calculation for NoahMP in comments

    commit c1d7a918a84ea7cf64f0b63948be73253584663a
    Author: Grant Firl <[email protected]>
    Date:   Fri Sep 6 12:06:09 2019 -0600

        fix bugs in FV3GFS_io.F90 related to #ifdef CCPP directives and noahmp

    commit 6e8b0cedd9d98ed469366603bae0bb95bc68a9b2
    Author: Grant Firl <[email protected]>
    Date:   Wed Sep 4 22:09:28 2019 -0600

        add t2mmp and q2mp to interstitial variables for noahmp

    commit 42915ea8e753f8be859f6ebf4f5983b4c78b695f
    Merge: b30a69a 1d823f8
    Author: Dom Heinzeller <[email protected]>
    Date:   Wed Sep 4 16:41:50 2019 -0600

        Merge pull request #202 from climbfuji/github_master_update_from_vlab_master_20190904

        Update GitHub master from Vlab master 2019/09/04

    commit 67db064b8d7b2e4b8692c8d5927a6897d49607d3
    Author: Dom Heinzeller <[email protected]>
    Date:   Wed Sep 4 15:39:01 2019 -0600

        gfsphysics/GFS_layer/GFS_typedefs.F90, gfsphysics/GFS_layer/GFS_typedefs.meta: add interstitial variables and their initialization, add metadata

    commit 635bd9f4f39f219fd6599ab724819db0279bc537
    Author: Grant Firl <[email protected]>
    Date:   Wed Sep 4 13:05:15 2019 -0600

        swap metadata for a couple of NoahMP precip variables

    commit 0b385edcb8344f0e2f515c63d91c27f43155d351
    Author: Jun.Wang <[email protected]>
    Date:   Tue Sep 3 01:37:04 2019 +0000

        FV3: this commits #refs 67151, Add aerosol transport to SAMF deep convection scheme, #refs 67152, Export instantaneous convective specific humidity tendency

    commit 599dd26768fb988763d6ad2c887432dbfe540d0b
    Author: Grant Firl <[email protected]>
    Date:   Wed Sep 4 10:52:25 2019 -0600

        remove accidentally reverted change in GFS_physics_driver.F90

    commit 1d823f846d64a4c6155565042c36f93a281a6887
    Author: Jun.Wang <[email protected]>
    Date:   Tue Sep 3 01:37:04 2019 +0000

        FV3: this commits #refs 67151, Add aerosol transport to SAMF deep convection scheme, #refs 67152, Export instantaneous convective specific humidity tendency

    commit f3b64a02ce0f6703b2b0ff60265a91f896e2a0c7
    Author: Grant Firl <[email protected]>
    Date:   Wed Sep 4 10:40:11 2019 -0600

        remove conversion factor-based directives in GFS_diagnostics.F90

    commit 39667a94d78187149a373029ac5bf008ab434fcc
    Merge: 5babb96 028a54e
    Author: Grant Firl <[email protected]>
    Date:   Wed Sep 4 10:31:50 2019 -0600

        Merge branch 'gmtb/develop' into noahmp

    commit fedc6695589c70f0415f9c8914d4e91b649fe937
    Merge: 3332314 179cbe7
    Author: Dom Heinzeller <[email protected]>
    Date:   Wed Sep 4 09:08:10 2019 -0600

        Merge branch 'gsd/develop' of https://github.com/NCAR/FV3 into gmtb_develop_update_from_master_20190830

    commit 3332314b09fa3a373e0ab132165a1453f6b23fa3
    Author: Dom Heinzeller <[email protected]>
    Date:   Wed Sep 4 08:27:44 2019 -0600

        Bugfixes in gfsphysics/GFS_layer/GFS_driver.F90, gfsphysics/GFS_layer/GFS_typedefs.F90 and gfsphysics/GFS_layer/GFS_typedefs.meta following the merge of the stochastic_physics separation PR

    commit 5babb964462e6913e3093462522b2430483905ea
    Author: Grant Firl <[email protected]>
    Date:   Tue Sep 3 15:50:59 2019 -0600

        remove directives in FV3GFS_io.F90 limiting NoahMP to non-CCPP build; add noahmp_tables.f90 (data only) to makefile for CCPP build (needed in FV3GFS_io.F90 for noahmp cold starts)

    commit ede4f37077c866bffb87261edf38e7a8ee388b67
    Merge: a721e0d 45ceeac
    Author: Grant Firl <[email protected]>
    Date:   Tue Sep 3 14:26:19 2019 -0600

        Merge branch 'fix_sncovr' into noahmp

    commit dbef968c7985c72dc9eabf75f5e65141506dbd38
    Author: Dom Heinzeller <[email protected]>
    Date:   Wed Jul 10 08:04:32 2019 -0600

        namphysics/NAM_layer/NAM_typedefs.F90, namphysics/NAM_layer/NAM_driver.F90: add new component blksz(:) to NAM_control (GFS_control) DDT, pass to init routine

    commit c79b844b35a101db7ed3971d0be7c6077c085cb7
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Jul 9 14:57:36 2019 -0600

        makefile: build_stochastic physics independently of IPD or CCPP in directory ../stochastic_physics

    commit 278a1f1aa0915b1bcccc86779cc7bd65ee42bc3b
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Jul 9 14:56:42 2019 -0600

        atmos_model.F90: call stochastic physics independently of IPD or CCPP

    commit 24543a1c4365485d782fa29de647512ef384ec81
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Jul 9 14:41:17 2019 -0600

        gfsphysics/GFS_layer/GFS_typedefs.F90: remove variables for CCPP that are no longer required, add blksz as component to GFS_control also for IPD (is already for CCPP)

    commit 76dccf55128cd961461688f2df3a3bd88d5189e0
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Jul 9 14:38:40 2019 -0600

        (1) remove directory stochastic_physics

        (2) gfsphysics/GFS_layer/GFS_driver.F90: remove calls to stochastic_physics, make Init_parm%blksz an input argument to Model%init for both IPD and CCPP

    commit 028a54ec8e0596892f9bc01d63df7a1c4867ec41
    Merge: d04664e 62fb7fb
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Sep 3 09:20:05 2019 -0600

        Merge pull request #199 from climbfuji/gmtb_develop_update_from_master_20190830

        gmtb/develop: update from master 2019/08/30

    commit b30a69a16b0b9cd91b49fe20ea4cf5773e65f26e
    Merge: 127baf5 a47b7fc
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Sep 3 08:21:34 2019 -0600

        Merge pull request #200 from climbfuji/update_submodule_pointer_in_FV3_20190903

        master: update submodule pointer for atmos_cubed_sphere

    commit a47b7fc2dfe3612b8d0ee8af6d523e3995cc93d8
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Sep 3 08:19:46 2019 -0600

        Update submodule pointer for atmos_cubed_sphere

    commit 127baf51f612a7c7f04ebe160b28657773840bac
    Merge: ef8bb54 088e5fa
    Author: Laurie Carson <[email protected]>
    Date:   Mon Sep 2 14:12:30 2019 -0600

        Merge pull request #198 from climbfuji/update_from_noaaemc_dev_20190830

        Update GitHub NCAR master from Vlab master

    commit 45ceeac46d3f3f6dbdcef9bfd9cd43bdc2b1c92c
    Author: Grant Firl <[email protected]>
    Date:   Fri Aug 30 16:04:41 2019 -0600

        remove calculation of sncovr from FV3GFS_io.F90 and from the makefile (for CCPP build)

    commit 62fb7fb3cf5900e6f71c4a7a52f6d6fbc3b629a1
    Author: Jun.Wang <[email protected]>
    Date:   Tue Aug 27 20:17:31 2019 +0000

        FV3: This commits #refs 66699, Calling radiative transfer parameterizations on each physics time step and #refs 66931,fix time window for accumulated fields in fv3 with IAU

    commit 9265ae03ec7af41420210a427149268118d81846
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Aug 30 12:04:36 2019 -0600

        Update .gitmodules and set default branch for atmos_cubed_sphere to gmtb/develop, update submodule pointer

    commit 1028b3f905d7f74f173a854d55fdc0a2ca6b7c82
    Author: Jun.Wang <[email protected]>
    Date:   Sun Aug 25 02:54:03 2019 +0000

        FV3: this commits #59519, separate FV3 dynamical core repository from FV3

    commit 088e5fa16afc1b3ffd3932294de83aa72c7971ac
    Author: Jun.Wang <[email protected]>
    Date:   Tue Aug 27 20:17:31 2019 +0000

        FV3: This commits #refs 66699, Calling radiative transfer parameterizations on each physics time step and #refs 66931,fix time window for accumulated fields in fv3 with IAU

    commit cf98bfae384ee3cb2969c69fafa19f79156ed15d
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Aug 30 08:36:09 2019 -0600

        Update .gitmodules to point to NCAR fork of GFDL_atmos_cubed_sphere

    commit 31e13942a8e543e365216b134895e6ceffef8a83
    Author: Jun.Wang <[email protected]>
    Date:   Sun Aug 25 02:54:03 2019 +0000

        FV3: this commits #59519, separate FV3 dynamical core repository from FV3

    commit d04664e793f8cff5502a5127ce03f1e19352f676
    Merge: 47fa9fb a5d2226
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Aug 30 07:39:08 2019 -0600

        Merge pull request #195 from climbfuji/github_gmtb_develop_address_physics_issue_300_and_coupled_code

        GitHub gmtb develop address physics issue 300 and coupled code

    commit ef8bb5470f7d53b4afc6087f7f601f4b8cd8ee80
    Merge: 8a86358 bd46b82
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Aug 29 15:33:03 2019 -0600

        Merge pull request #197 from grantfirl/master

        add Julie as codeowner

    commit 47fa9fbb67fdfe1d7ace52282fc8974eea9b1a03
    Merge: 21fdde6 561eb79
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Aug 29 15:32:36 2019 -0600

        Merge pull request #196 from grantfirl/gmtb/develop

        add Julie as codeowner

    commit bd46b82d013091fcf36f75ab04624c55efd96dd3
    Author: Grant Firl <[email protected]>
    Date:   Thu Aug 29 15:07:57 2019 -0600

        add Julie as codeowner

    commit 561eb79d9133f1b285eb1503bbad5c24d6f460dc
    Author: Grant Firl <[email protected]>
    Date:   Thu Aug 29 15:05:15 2019 -0600

        add Julie as codeowner

    commit a5d2226d5d37464e9feea05b32db08572468fb16
    Author: Dom Heinzeller <[email protected]>
    Date:   Wed Aug 28 17:29:25 2019 -0600

        gfsphysics/GFS_layer/GFS_typedefs.meta: rename instantaneous_upward_sensible_heat_flux to instantaneous_surface_upward_sensible_heat_flux_for_chemistry_coupling

    commit 5fac92183886479afc473bd01b9cd70840bd54fc
    Merge: b803db9 7ffc16a
    Author: Dom Heinzeller <[email protected]>
    Date:   Wed Aug 28 10:03:12 2019 -0600

        Merge branch 'gmtb/develop' of https://github.com/panll/FV3 into HEAD

    commit b803db9182aad295b64e9d62052a4e601dd029fe
    Merge: 21fdde6 fd929f1
    Author: Dom Heinzeller <[email protected]>
    Date:   Wed Aug 28 10:02:36 2019 -0600

        Merge branch 'fix_LSM_units' of https://github.com/grantfirl/FV3 into HEAD

    commit 179cbe760b1d06960fecafb811241f0a6f2293d4
    Merge: 0591b5c 7994ef9
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Aug 27 16:38:23 2019 -0600

        Merge pull request #190 from grantfirl/fix_RUC_LSM_precip_partitioning

        Address ccpp-physics issue #301

    commit 21fdde6b7db39fa24ff667a42b3f79edeab50e1e
    Merge: a26436b 2f5bd1e
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Aug 27 16:29:54 2019 -0600

        Merge pull request #194 from climbfuji/gmtb_develop_fix_RUC_LSM_precip_partitioning

        gmtb/develop: address issue #301 (fix RUC LSM precip partitioning)

    commit fd929f175da3b3e3ba16c0984f46f97e6246c1be
    Author: Grant Firl <[email protected]>
    Date:   Tue Aug 27 16:27:48 2019 -0600

        fix soil moisture units in non-CCPP sfc_drv.f and sfc_noahmp_drv.f

    commit a721e0d3c2913dd1fa174b0fb3741b802e5b4c4f
    Author: Grant Firl <[email protected]>
    Date:   Tue Aug 27 15:02:51 2019 -0600

        remove stop for NoahMP LSM through CCPP in GFS_typedefs.F90

    commit dcd9771211b2476000e968b02ebedc7e35f0f4a7
    Author: Grant Firl <[email protected]>
    Date:   Tue Aug 27 13:43:37 2019 -0600

        wrap removal of conversion factors for 3 variables in GFS_diagnostics.F90 in #ifndef CCPP directives

    commit 2f5bd1ef13db0b857b03b2e43f7b5bfb930d8470
    Author: Grant Firl <[email protected]>
    Date:   Tue Aug 20 14:13:34 2019 -0600

        fix CCPP metadata for convective/non-convective precip variables used in RUC LSM

    commit a26436be1da9816330d375fb111e79204398aaee
    Merge: 44d9541 6363392
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Aug 27 07:13:16 2019 -0600

        Merge pull request #186 from bluefinweiwei/cires_ugwp

        UGWP Version 0

    commit bcfed5b20a6b18f5e9ad96b16763889a0fb0c4b6
    Author: Qingfu Liu <[email protected]>
    Date:   Tue Aug 27 11:17:39 2019 +0000

        add MYJ surface layer scheme and MYJ PBL scheme to CCPP

    commit 2f5183ea7052fa39592f8b0fbec36326174526c9
    Author: Grant Firl <[email protected]>
    Date:   Mon Aug 26 13:32:59 2019 -0600

        move julian and yearlen to GFS_control_type (from interstitial) and add metadata for vars needed in GFS_time_vary_pre_run

    commit 636339227e9948feb58e4848a8983c822bbe831a
    Merge: 07b2f1f 0b22293
    Author: Weiwei <[email protected]>
    Date:   Fri Aug 23 13:23:21 2019 -0600

        Merge pull request #1 from climbfuji/ugwd_dom

        UGWD update for open PR to gmtb/develop

    commit 0b2229387070e966b5bc6892bd9704d7e57a239c
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Aug 23 11:59:01 2019 -0600

        gfsphysics/GFS_layer/GFS_typedefs.meta: correct variable dimensions

    commit 95071efdde50b128749f5719dce45fc1b2e52729
    Author: Grant Firl <[email protected]>
    Date:   Fri Aug 23 11:11:07 2019 -0600

        add density of liquid water to constants available to CCPP schemes

    commit f7b7df469022a7d74fd43591aabc57ba7e4ddbcf
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Aug 23 08:52:51 2019 -0600

        gfsphysics/GFS_layer/GFS_physics_driver.F90: update CCPP comments for UGWP code changes

    commit 539d331b5f578dd0c22b2131b54662cfff8839dd
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Aug 23 08:52:22 2019 -0600

        gfsphysics/GFS_layer/GFS_typedefs.{meta,F90}: import con_p0, use instead of locally defined p_ref, add metadata

    commit 5717d0f19ea5b61010910fc0bf50b2529650dd21
    Author: Grant Firl <[email protected]>
    Date:   Thu Aug 22 13:32:30 2019 -0600

        change comments to reflect locations of NoahMP interstitial code

    commit a43041878ed867ec04f3d863559089d2c5d20fef
    Merge: 9ffcba3 44d9541
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Aug 22 11:19:43 2019 -0600

        Merge branch 'gmtb/develop' of https://github.com/NCAR/FV3 into ugwd_dom

    commit 9ffcba3b817c779dfbd7d7b7fe84d2228b9c652e
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Aug 22 11:19:16 2019 -0600

        gfsphysics/GFS_layer/GFS_typedefs.F90: remove unnecessary comment

    commit 44d95416b0921f5947e93f3aa29ef31ab1b73d4a
    Merge: e4e7ee6 cef4ace
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Aug 22 11:17:41 2019 -0600

        Merge pull request #191 from climbfuji/bugfix_gfdlmp_ccpp

        gmtb/develop: bugfix for CCPP GFDL-MP when effective radii are not used

    commit 697003f6b26443df0f385b17a2202f70d0f4b476
    Merge: e4e7ee6 07b2f1f
    Author: Dom Heinzeller <[email protected]>
    Date:   Wed Aug 21 14:24:23 2019 -0600

        Merge branch 'cires_ugwp' of https://github.com/bluefinweiwei/FV3 into HEAD

    commit 04e913f0b90264dc97b122bb1ab789beedde9547
    Author: Grant Firl <[email protected]>
    Date:   Wed Aug 21 13:30:00 2019 -0600

        initial addition of NoahMP variables to GFS_typedefs.F90

    commit 7994ef98ad93bc5999d9a105cba3773ae84da6b5
    Author: Grant Firl <[email protected]>
    Date:   Tue Aug 20 14:13:34 2019 -0600

        fix CCPP metadata for convective/non-convective precip variables used in RUC LSM

    commit ab4264fdd0128ca39897b324ed71aa8b113ed6ad
    Author: Grant Firl <[email protected]>
    Date:   Tue Aug 20 13:50:54 2019 -0600

        removed conversion factor for soil moisture and runoff diagnostics since they now have the desired units directly in physics code; corrected CCPP units in GFS_typedefs.meta

    commit 7ffc16a7ed7f759e414529cd8873417e0dae408d
    Author: Linlin.Pan <[email protected]>
    Date:   Mon Aug 19 21:52:12 2019 +0000

        adding couple option in CCPP with modified variable names.
        passed regression tests.

    commit 7f7e0a226264cd8928282cabad4822b41f019ddb
    Merge: 915dafd e4e7ee6
    Author: panll <[email protected]>
    Date:   Mon Aug 19 09:55:48 2019 -0600

        Merge pull request #1 from NCAR/gmtb/develop

        Gmtb/develop

    commit cef4ace8dbb72e551b452743590f1e39739a5c6d
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Jul 18 10:58:56 2019 -0600

        gfsphysics/GFS_layer/GFS_typedefs.F90: bugfix for GFDL-MP in CCPP when effective radii are not used

    commit 0591b5c5100d75a79c604d9e91985a8a75aaf60b
    Merge: a6ce9d4 c9606fb
    Author: Dom Heinzeller <[email protected]>
    Date:   Mon Aug 19 08:48:29 2019 -0600

        Merge pull request #188 from climbfuji/update_gsd_develop_with_vlab_master_20190816

        Update GitHub gsd/develop with Vlab master 2019/08/16

    commit e4e7ee6c640ca64b0ad8915c8ee06631c3c5590c
    Merge: 0af7e33 b7b423c
    Author: Dom Heinzeller <[email protected]>
    Date:   Sat Aug 17 16:25:45 2019 -0600

        Merge pull request #184 from climbfuji/bugfix_allocating_dtdt_m_non_ccpp_version

        Bugfix for allocating dtdt_m in fv_dynamics.F90

    commit c9606fba7e19ab86aa60b002f9ccd972b754d219
    Author: Dusan Jovic <[email protected]>
    Date:   Fri Jul 26 13:45:14 2019 +0000

        Fix an issue introduced in the previous commit where merge conflict markers were inadvertently committed.

    commit 02efdda480a2d1b610e3057d95fa4ac6f21d6ca6
    Author: Jun.Wang <[email protected]>
    Date:   Thu Jul 18 15:21:28 2019 +0000

        FV3: This commits #refs 65267 adding obs-based roughness length formulations and adjustment of K for hurricane simulations

        Change-Id: Ifea0ed42e7611648f4daa2dc24921561b4080691

    commit 8a86358617ff8bc39731b6f8a84128cfb3e74075
    Merge: 396b10d 319bb44
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Aug 16 11:36:41 2019 -0600

        Merge pull request #187 from climbfuji/update_github_master_from_vlab_master_20190816

        Update GitHub master from Vlab master 2019/08/16

    commit 319bb4411a8884493430166b2c4953bd5166e7a2
    Author: Dusan Jovic <[email protected]>
    Date:   Fri Jul 26 13:45:14 2019 +0000

        Fix an issue introduced in the previous commit where merge conflict markers were inadvertently committed.

    commit b757a06cbb507adcf73b85256cf8ed1869b8e425
    Author: Jun.Wang <[email protected]>
    Date:   Thu Jul 18 15:21:28 2019 +0000

        FV3: This commits #refs 65267 adding obs-based roughness length formulations and adjustment of K for hurricane simulations

        Change-Id: Ifea0ed42e7611648f4daa2dc24921561b4080691

    commit 07b2f1f9e7db1155463698956755cd9b899ce0b7
    Author: Weiwei <[email protected]>
    Date:   Tue Jul 16 14:57:32 2019 -0600

        	modified:   GFS_typedefs.F90
        	modified:   GFS_typedefs.meta

    commit 915dafd466c0b7195d1e494d327feb55d4da8981
    Author: Linlin.Pan <[email protected]>
    Date:   Thu Aug 15 04:43:15 2019 +0000

        adding new variables for coupling option in CCPP:

        gfsphysics/GFS_layer/GFS_typedefs.F90 -- new variables allocation and initiation included
        gfsphysics/GFS_layer/GFS_typedefs.meta -- new variables definiation  added

    commit b7b423cbf65f30f2c2a2d928c6814d746cbf202e
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Aug 9 11:47:51 2019 -0600

        atmos_cubed_sphere/model/fv_dynamics.F90: always allocate dtdt_m, because its dimensions are hardcoded in fv_mapz.F90

    commit dfb7db58bd44c48853ae6cd55efeaa731e3afa5f
    Merge: 0af7e33 a3ea903
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Aug 8 14:05:59 2019 -0600

        Merge branch 'MG_array_allocation' of https://github.com/grantfirl/FV3 into HEAD

    commit 0af7e331bdc79d81a9f0daf6f7a4d64e9170a440
    Merge: b1d8ec4 5b4c6e5
    Author: grantfirl <[email protected]>
    Date:   Tue Aug 6 13:45:45 2019 -0600

        Merge pull request #180 from grantfirl/add_interstitial_comments

        Document locations of CCPP-implemented code within GFS_physics_driver.F90

    commit 5b4c6e5e51738c28fd4616e7cb5ee401817f37b6
    Author: Grant Firl <[email protected]>
    Date:   Thu Aug 1 16:35:28 2019 -0600

        fix comment related to stochastics in GFS_driver.F90

    commit f8f792b889ab19a6c99384c7b1453144ab263bc6
    Merge: 4dc853b b1d8ec4
    Author: Grant Firl <[email protected]>
    Date:   Thu Aug 1 14:52:11 2019 -0600

        Merge branch 'gmtb/develop' into add_interstitial_comments

    commit b1d8ec4d6eb4d4f7519c608fe5f76fbacd8e7f6c
    Merge: c4712c2 5d14eec
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Aug 1 14:46:23 2019 -0600

        Merge pull request #181 from climbfuji/new_metadata_format_step1_20190725

        Migrate to new metadata format step 1

    commit 4dc853b8ca35494376b8e811f1f2916f61b648a6
    Merge: 31e0cc6 c4712c2
    Author: Grant Firl <[email protected]>
    Date:   Thu Aug 1 14:00:56 2019 -0600

        Merge branch 'gmtb/develop' into add_interstitial_comments

    commit 31e0cc65bf4eea12e2072c5f3edd9011c99a1bd1
    Author: Grant Firl <[email protected]>
    Date:   Thu Aug 1 13:53:25 2019 -0600

        add comments in GFS_driver.F90 and GFS_radiation_driver.F90 to tell users locations of code in the CCPP

    commit 5d14eec31116d3b2f4902695c9f12a05f6748d70
    Merge: f575b62 417f8ce
    Author: Dom Heinzeller <[email protected]>
    Date:   Wed Jul 31 15:47:56 2019 -0600

        Merge branch 'master' of gerrit:FV3 into new_metadata_format_step1_20190725

    commit f575b6205aafc91e2d37130febe9a6934e2e352b
    Author: Dom Heinzeller <[email protected]>
    Date:   Wed Jul 24 16:44:16 2019 -0400

        gfsphysics/GFS_layer/GFS_typedefs.F90: add metadata for new HAFS variable GFS_Control%sfc_z0_type

    commit 3990afc75001f55529d0be960ad7ea149715f669
    Author: Dom Heinzeller <[email protected]>
    Date:   Wed Jul 31 14:17:45 2019 -0600

        Convert CCPP type and variable definitions to new metadata format, introduce variables for all dimensions needed, add comments about further work

    commit a3ea903db48889bf163b33f7fbc6644fae8f1731
    Author: Grant Firl <[email protected]>
    Date:   Wed Jul 31 12:41:08 2019 -0600

        conditionally allocate arrays for Morrison-Gettelman microphysics scheme

    commit 7b4db3ea1751644174dc22c1d8f5e34c3176bf12
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Jul 25 16:31:42 2019 -0600

        gfsphysics/CCPP_layer/CCPP_typedefs.F90, gfsphysics/GFS_layer/GFS_typedefs.F90: substitute dashes with underscores in variable standard names

    commit 2cdcc3b4d6af372194c52293b537de759d36bed4
    Author: Grant Firl <[email protected]>
    Date:   Sun Jul 21 19:13:19 2019 -0600

        add comments in GFS_physics_driver.F90 to tell users locations of code in the CCPP

    commit a6ce9d412e31a865116183c817fd5f0db40c44db
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Jul 18 10:45:01 2019 -0600

        Update CODEOWNERS to enable branch protection

    commit 9def0cf844a3bc743c842e35a070128b9fc0035d
    Merge: a5c8b40 780d3a8
    Author: Dom Heinzeller <[email protected]>
    Date:   Wed Jul 17 20:48:05 2019 -0600

        Merge pull request #179 from climbfuji/add_regression_tests_20190717

        gsd/develop: add regression tests for Thompson only, GF only, MYNN only & cleanup

    commit 780d3a87df3dd7749d960af0bfac876c553c21a7
    Author: Dom Heinzeller <[email protected]>
    Date:   Wed Jul 17 14:13:03 2019 -0600

        Remove namelist option make_number_concentrations, this will be used by default for Thompson MP

    commit a5c8b40e37ebb410e721e00f04350086b27da834
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Jul 16 15:00:57 2019 -0600

        Update CODEOWNERS to GSD team

    commit 1cfdbb099f5ff7bcc30e0290ea3c8aaf7f0f714b
    Merge: 9595fb7 c4712c2
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Jul 16 14:52:54 2019 -0600

        Merge branch 'gmtb/develop' of https://github.com/NCAR/FV3 into HEAD

    commit c4712c233cb6cb5d68e1dd050fd3a4889c20f53d
    Merge: ae1d3d9 d0359b3
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Jul 16 14:46:17 2019 -0600

        Merge pull request #178 from climbfuji/update_gmtb_develop_from_vlab_master_20190716

        Update gmtb/develop from Vlab master 2019/07/16

    commit d0359b3f8f8ec129b3be65a6aafde203bbfb4f1f
    Merge: ae1d3d9 64fc1f1
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Jul 16 14:41:30 2019 -0600

        Merge branch 'master' of gerrit:FV3 into HEAD

    commit 396b10dcbd91c577a0dfb3094e2cd0d463f1046a
    Merge: c4ef4b0 e0fed0f
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Jul 16 14:37:34 2019 -0600

        Merge pull request #177 from climbfuji/update_master_github_from_master_vlab

        Update master GitHub from master Vlab

    commit e0fed0fdda5b8d290cae2a5550f1baf9c8977b92
    Merge: c4ef4b0 64fc1f1
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Jul 16 14:33:18 2019 -0600

        Merge branch 'master' of gerrit:FV3 into HEAD

    commit ae1d3d92ad53af377789e1b353dbdc96e65cb66c
    Merge: 5c1fb7d 9207155
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Jul 16 14:23:13 2019 -0600

        Merge pull request #176 from climbfuji/bugfix_gf_conv_AND_thompson_cleanup_20190709

        Bugfix GF convection, Thompson cleanup 2019/07/09

    commit 5c1fb7dc24337aecc5abcd08fad0c0c776f43cc6
    Merge: 981af01 dfe41ca
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Jul 11 08:37:15 2019 -0600

        Merge pull request #175 from climbfuji/update_from_github_master_20190708

        Update from GitHub (=VLab) master 2019/07/08

    commit 9207155591cf01f0825105dcd8f708e32ceeecae
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Jul 9 10:31:31 2019 -0600

        gfsphysics/GFS_layer/GFS_typedefs.F90: adjust number of tracers in PBL tracer array for Thompson MP, add guard to prevent running Thompson MP with cplchm (not configured)

    commit dfe41ca3b68c4fdc6c5c30e6ed1a38a39b25f618
    Merge: d27d347 c4ef4b0
    Author: Dom Heinzeller <[email protected]>
    Date:   Mon Jul 8 11:24:40 2019 -0600

        Merge branch 'master' of https://github.com/NCAR/FV3 into HEAD

    commit d27d34737295bb5f3a30581c92aa11fc665edba1
    Merge: 981af01 3dc7e9b
    Author: Dom Heinzeller <[email protected]>
    Date:   Mon Jul 8 11:24:07 2019 -0600

        Merge branch 'master' of gerrit:FV3 into HEAD

    commit c4ef4b0944a1dbbea4a371a5f98cf18f407f181e
    Author: Dom Heinzeller <[email protected]>
    Date:   Mon Jul 8 08:23:56 2019 -0600

        Add CODEOWNERS after mirroring Vlab master

    commit 981af01d87d8b302cafd19cfb07e66443f7a18d4
    Merge: 66b1f26 3e3b1b7
    Author: Dom Heinzeller <[email protected]>
    Date:   Wed Jul 3 07:58:40 2019 -0600

        Merge pull request #173 from climbfuji/cleanup_work_gerrit_codereview_20190701

        Cleanup work gerrit codereview 2019/07/01

    commit 3e3b1b701466a9884217d36a5e729866acfd7f7d
    Author: Dom Heinzeller <[email protected]>
    Date:   Mon Jul 1 13:44:35 2019 -0600

        gfsphysics/GFS_layer/GFS_physics_driver.F90: comment out unneccessary/redundant code as per code review

    commit 66b1f26a0d5b576c2c7b39d6a009c8fb7d4822c4
    Merge: 132bd90 754129f
    Author: Dom Heinzeller <[email protected]>
    Date:   Sun Jun 30 20:25:43 2019 -0600

        Merge pull request #172 from climbfuji/cleanup_work_gerrit_codereview_20190627

        Cleanup work gerrit code review part 2 - 2019/06/29

    commit 754129f5d24c092edc9e7f91031217a3d6bae485
    Author: Dom Heinzeller <[email protected]>
    Date:   Sat Jun 29 09:30:17 2019 -0600

        Optimization (CCPP-only): allocate Noah MP restart variables only if Noah MP is actually used

    commit 6b54841392e5cc9c9fab6ef3d64ab3af0be8eefb
    Author: Dom Heinzeller <[email protected]>
    Date:   Sat Jun 29 06:52:25 2019 -0600

        CCPP_layer/makefile,  gfsphysics/makefile: set CPP directives for promoting dynamics/fast physics to 32-bit

    commit 4899b5d9d979dc96b9f6a1978adf81156867ee81
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Jun 28 14:22:23 2019 -0600

        gfsphysics/physics/GFS_debug.F90, gfsphysics/GFS_layer/GFS_physics_driver.F90, gfsphysics/GFS_layer/GFS_diagnostics.F90: bugfixes following the reverse of the Diag%{wet1,sr} -> Sfcprop{wet1,sr} change

    commit afb55926beb9255813e011e7c82bbe93c5beefab
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Jun 28 13:48:57 2019 -0600

        atmos_cubed_sphere/tools/external_ic.F90: add CPP guard to logic for reading in Thompson aerosols

    commit 50576da069d45a9d6602cb9301db04163f3331da
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Jun 28 13:46:49 2019 -0600

        gfsphysics/GFS_layer/GFS_physics_driver.F90, gfsphysics/physics/physcons.F90, gfsphysics/physics/sfc_sice.f: revert cimin changes (moved from sfc_sice to physcons) for non-CCPP builds

    commit a3f9fefd27f45b6ef64930648532c65c29bcca4c
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Jun 28 13:40:31 2019 -0600

        gfsphysics/physics/radiation_clouds.f: fix bug for radiation-clouds in Thompson/WSM6 cloud scheme

    commit d01ebbc1205d39e744b40fd4efb202804974fa78
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Jun 28 13:37:46 2019 -0600

        gfsphysics/GFS_layer/GFS_typedefs.F90, io/FV3GFS_io.F90: RUC now uses srflag and not sr, revert change of moving sr from Diag to sfcprop, and remove sr from restart information for RUC

    commit ef9936381fbd26276147ca58010e24a71a25728b
    Merge: a00ec68 132bd90
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Jun 27 22:45:25 2019 -0600

        Merge branch 'gmtb/ccpp' of https://github.com/NCAR/FV3 into cleanup_work_gerrit_codereview_20190627

    commit a00ec683be47562518240938f72783f652973c8e
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Jun 27 22:45:10 2019 -0600

        io/FV3GFS_io.F90: rename wetness variable for RUC LSM from wet1 to wetness

    commit f0fa127d278f2a1321560e190f7e80698839238e
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Jun 27 22:43:26 2019 -0600

        gfsphysics/GFS_layer/GFS_typedefs.F90: use different wetness variables for RUC LSM and other LSMs, update metadata for CCPP

    commit 9f21fe1c50dd33e99a8d6d3d94402f0ec01cd192
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Jun 27 22:41:42 2019 -0600

        gfsphysics/GFS_layer/GFS_diagnostics.F90: use different wetness variables for RUC LSM and other LSMs, cleanup code for subsurface variables, rename RUC LSM soill output to slc to be consistent with Noah MP

    commit 132bd90db5f033d479eb0892e840cd5b03fa1bb9
    Merge: 7ab6d31 00db91c
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Jun 27 22:32:52 2019 -0600

        Merge pull request #171 from climbfuji/cleanup_work_gerrit_codereview_20190626

        Cleanup work for CCPP transition 2019/06/27 - 1

    commit 00db91cd2f37e84a747bab70dedbdc607e54ce3b
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Jun 27 11:21:23 2019 -0600

        ipd/IPD_typedefs.F90: cleanup code, remove remaining remnants of old HYBRID build, remove unused IPD_finalize

    commit 009d0bf91514ba1fbc69b28014d0b50ff0da0e70
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Jun 27 11:20:05 2019 -0600

        ipd/IPD_driver.F90: cleanup code, remove remaining remnants of old HYBRID build, remove unused IPD_finalize

    commit 953cb7f8542b094b10b84bf1eecd0a66cd9944be
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Jun 27 11:19:12 2019 -0600

        gfsphysics/GFS_layer/GFS_typedefs.F90: check and remove old comments as needed, remove standard_name for composite dq3dt to prevent its usage, allocate d?3dt arrays for CCPP only if ldiag3d is true

    commit 135d62927a63f8487858f94586e81e760f505d5b
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Jun 27 11:17:14 2019 -0600

        gfsphysics/GFS_layer/GFS_driver.F90: cleanup code, remove unused GFS_finalize

    commit c0abdb637c9c77df9887d5342c5e4394cee3b311
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Jun 27 11:16:41 2019 -0600

        gfsphysics/GFS_layer/GFS_abstraction_layer.F90: cleanup code, remove remaining remnants of old HYBRID build, remove unused GFS_finalize

    commit 9fd64b4d366997fa751c07d46e3d8f9b2bb81945
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Jun 27 11:16:08 2019 -0600

        atmos_model.F90: cleanup code, remove remaining remnants of old HYBRID build

    commit 97f665fb5c2436f0f436f51cb77fbabc87e09f31
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Jun 27 11:15:10 2019 -0600

        atmos_cubed_sphere/tools/external_ic.F90: remove unnecessary comments

    commit 226b417ac8da6af8bffed3b7567f0a409b311d7f
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Jun 27 11:14:30 2019 -0600

        atmos_cubed_sphere/model/fv_regional_bc.F90: remove unnecessary comments

    commit eb1c50563e3f0d6189c01be15b3e4b4b1f12c680
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu Jun 27 11:12:05 2019 -0600

        CCPP_layer/CCPP_driver.F90: Simplify physics_init, run over entire domain instead of multiple blocks

    commit 00a02ca2cdff5bc5625739015853102d270726af
    Author: Dom Heinzeller <[email protected]>
    Date:   Wed Jun 26 11:56:45 2019 -0600

        makefile: set SIONLIB_LINK_FLAGS only for CCPP build, do not add to non-CCPP ESMF makefile fragment

    commit 7ab6d3111322e306251e50ffc88bd1efa8d7e310
    Merge: 386ab98 0e12270
    Author: Dom Heinzeller <[email protected]>
    Date:   Wed Jun 26 08:43:58 2019 -0600

        Merge pull request #170 from climbfuji/ruclsm_b4b_20190625

        RUC LSM b4b through restarts, cleanup for Thompson MP / effective radii / debug output

    commit 0e122708f6f8ef3a92ce3ff4638cb9d6b94e115a
    Merge: c9cbbc8 386ab98
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Jun 25 21:25:58 2019 -0600

        Merge branch 'gmtb/ccpp' of https://github.com/NCAR/FV3 into ruclsm_b4b_20190625

    commit c9cbbc8a21b46987e0fa170650d8117882c40509
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Jun 25 21:25:22 2019 -0600

        gfsphysics/physics/GFS_debug.F90: comment out Diag%fluxr components, not required for b4b (purely diagnostic and not in output)

    commit 6635068b4dc8b8916fa2903b0e2bf721b0917b9a
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Jun 25 21:24:20 2019 -0600

        gfsphysics/GFS_layer/GFS_typedefs.F90: improve debug print of dry/wet/icy components of CCPP interstitial type

    commit 386ab989b837db3a6bbd9c47c2911673c3c8af6e
    Merge: 470681c 6ce0582
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue Jun 25 08:26:01 2019 -0600

        Merge pull request #169 from NCAR/bugfix_gfs_phy_tracer_config_suffix

        Bugfix gfs phy tracer config suffix .f -> .F

    commit 6ce05823d64a49151d38e48a4dc960fd6a6cc3a6
    Author: climbfuji <[email protected]>
    Date:   Tue Jun 25 08:24:16 2019 -0600

        Bugfix: fix suffix of physics/gfs_phy_tracer_config.f->F

    commit 470681c382fd0d62a3cf45ca372bb06f31e16df9
    Merge: d60d8e6 abb621f
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Jun 21 08:59:35 2019 +0200

        Merge pull request #168 from climbfuji/ccpp_github_update_vlab_master_20190611

        CCPP GitHub update from VLab master 2019/06/11

    commit abb621fe28a61ff26cfc04849217b8cf3030e92d
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri Jun 14 09:54:17 2019 -0600

        This commit combines three commits to Vlab master (NEMSfv3gfs and FV3):

        commit ee9977192f6782df21d2af23979ec67683ac020e
        Author: Dusan Jovic <[email protected]>
        Date:   Mon Jun 10 14:20:34 2019 +0000

            NEMSfv3gfs: this commits #refs 56264: support fractional landmask on FV3 grid, and #refs 64400: bug fix for UGW and in CSAW

            Change-Id: Id42e31a8b32ba52dd810e98dff059b14135884ec

        commit a0fca321ffd9fff1e929c00f3e6d467154610065
        Author: Dusan Jovic <[email protected]>
        Date:   Thu Jun 6 13:54:04 2019 +0000

            NEMSfv3gfs: this commits #refs 64015 Add updated scale-aware TKE-based moist EDMF scheme. Updated fv3_cap #refs 62862

            Change-Id: Ic6a04044bd2826a3a4be700e77067ff435fadc56

        commit a2c9fdabf3aa1e99ab8037c319820c9e440fb894
        Author: Jun Wang <[email protected]>
        Date:   Tue Jun 4 01:26:37 2019 +0000

            NEMSfv3gfs: this commits #refs 61507, coupling Noah MP to fv3gfs

            Change-Id: Ia3b86d247d98ee143e47b5e41fce3ae92dde0564

    commit d60d8e638f12bc6ebfb77a042b0f75774f47eb5c
    Merge: 7d6c953 d00e8e6
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu May 30 22:00:51 2019 -0600

        Merge pull request #162 from climbfuji/bugfix_fractional_landmask_and_cleanup

        Bugfix fractional landmask, scientific documentation update, cleanup

    commit d00e8e6d8c80e9f1f409fa3abb52f5a864efd738
    Merge: f42c3ed 7d6c953
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu May 30 08:41:54 2019 -0600

        Merge branch 'gmtb/ccpp' of https://github.com/NCAR/FV3 into bugfix_fractional_landmask_and_cleanup

    commit 7d6c95383258c9b9813614953876a191bce8b55b
    Merge: 9adc6bc e90a8de
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu May 30 06:34:35 2019 -0600

        Merge pull request #161 from climbfuji/gsd_suite_cleanup_and_fractional_landmask_follow_up

        GSD suite cleanup and fractional landmask follow up

    commit f42c3ed52f50286fa65117c879dd8f0b7d0b0fc3
    Author: shan.sun <[email protected]>
    Date:   Fri May 24 16:10:37 2019 +0000

        1.) Revert back to 1f45136245cde52b39e93ab29f0d36020b0f7e63 :
            This rewinds cleanup in sfc_diag.f and GFS_physics_driver.F90
        2.) Then, fix bug for ice point to be from ">15%" to ">=15%" to be consistent with initial condition, which defines slmsk=2 for >=15%.
            This bugfix is in the following files:
            GFS_physics_driver.F90
            atmos_model.F90

    commit e90a8dec3a9e56357b0a934e6dd02f7b587e3161
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue May 28 15:56:39 2019 -0600

        atmos_cubed_sphere/driver/fvGFS/atmosphere.F90: improve error handling/output for CCPP fast physics

    commit 43854a221fbf255cc84657b5ea567440855cf2a4
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue May 28 15:09:26 2019 -0600

        io/FV3GFS_io.F90: remove temporary filling of top four Noah levels with RUC levels when restarting from RUC LSM data

    commit aefb214c4da67cfc78036523c4447092157719a3
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue May 28 15:08:33 2019 -0600

        gfsphysics/GFS_layer/GFS_typedefs.F90: add consistency check that surface data cycling is turned off when RUC LSM is used

    commit 18414f2c682db5da35c8f7861d8eec29ef96b8f1
    Author: Dom Heinzeller <[email protected]>
    Date:   Tue May 28 15:07:54 2019 -0600

        gfsphysics/GFS_layer/GFS_diagnostics.F90: write out all subsurface layers for RUC LSM; facilitate and shorten the code for writing out subsurface layers for both RUC and Noah for the CCPP version

    commit 9adc6bc261764c18292a3f258a0c6d3888e36c52
    Merge: 56bffa3 e79d445
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri May 24 13:59:58 2019 -0600

        Merge pull request #158 from climbfuji/remove_hybrid_ccpp

        Remove CCPP HYBRID mode

    commit e79d445faf8d3d7594034ca0785a9c982a17baea
    Author: Dom Heinzeller <[email protected]>
    Date:   Fri May 24 05:22:57 2019 -0600

        gfsphysics/GFS_layer/GFS_physics_driver.F90: rearrange to match Vlab master code more closely

    commit 2a61d4a9a15834eb9e02801513b2a4c472c79b0a
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu May 23 16:18:35 2019 -0600

        Remove HYBRID CCPP build

    commit 56bffa38043839dd3f867aa53d943610cf6e9b13
    Merge: 8657c50 83fa5b9
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu May 23 11:47:19 2019 -0600

        Merge pull request #157 from climbfuji/ccpp_cleanup_20190523

        CCPP cleanup 2019/05/23 - remove temporary files

    commit 83fa5b9f7f5fd8b677635f4d76813d122fcb3c98
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu May 23 11:21:35 2019 -0600

        Remove temporary files gfsphysics/GFS_layer/GFS_typedefs.{ipd,ccpp}.F90 and remove comments to them in gfsphysics/makefile

    commit 8657c5074300810430692760ce475649c3119070
    Merge: 789a135 54fecdd
    Author: Dom Heinzeller <[email protected]>
    Date:   Thu May 23 10:53:59 2019 -0600

        Merge pull request #156 from climbfuji/cleanup_ccpp_build

        CCPP cleanup 2019/05/13

    commit 54fecdda7f950ef9afbe3d8700174d7ba8cfa03a
    Author: Dom Heinzeller <[email protected]>
    Date:   Mon May 20 16:06:06 2019 -0600

        gfsphysics/makefile: remove two-step compilation of GFS_typedefs.F90, this causes compile errors with Intel (compiler bug)

    commit c885e896eb0b058e82fa50345ec0ce7f07056329
    Author: Dom Heinzeller <[email protected]>
    Date:   Mon May 20 14:06:11 2019 -0600

        TEMPORARY: add original, merged GFS physics driver as gfsphysics/GFS_layer/GFS_physics_driver.F90.original - to be deleted once a final decision is made if/how to support the hybrid mode in the transition Vlab master

    commit 759af12ec9e90b915ee2bb4b7e7f48caa8cfa427
    Author: Dom Heinzeller <[email protected]>
    Date:   Mon May 20 10:50:00 2019 -0600

        Reverse whitespace changes to FV3 code

    commit 9b1bbadc5f026d6b13008ce8b37734827bea6329
    Author: Dom Heinzeller <[email protected]>
    Date:   Sat May 18 21:15:40 2019 -0600

        Split gfsphysics/GFS_layer/GFS_typedefs.F90 into an IPD-only and a CCPP-only version, but don;t use yet; adjust makefile; revert whitespace changes in all three versions

        to merge with previous commit of GFS_typedefs.F90, change wording
…
SamuelTrahanNOAA added a commit to SamuelTrahanNOAA/fv3atm that referenced this pull request Oct 3, 2022
@SamuelTrahanNOAA
Replace many changes with atmos_cubed_sphere PR NOAA-EMC#220
29ad78a
jkbk2004 pushed a commit that referenced this pull request Oct 17, 2022
@SamuelTrahanNOAA
Fix boundary issues and numerical precision trouble in RUC LSM (#587)
2458535 
* fixes and workarounds for uninitialized memory in fv_regional_bc

* initialize kmaxfire in module_bl_mynn

* smoke bug fixes for restart

* remove smoke bug fixes

* remove workarounds and fix remaining known bugs in ps_reg

* a few more surface pressure bug fixes; now the test case runs in debug mode

* ccpp/physics: module_sf_ruclsm imprecision workaround for gfortran -DDEBUG=ON

* move sanity checks to lsm_ruc and add "snow on ice" check

* use i-1 & j-1 for two-point averages, when available

* Replace many changes with atmos_cubed_sphere PR #220
LarissaReames-NOAA pushed a commit to LarissaReames-NOAA/fv3atm that referenced this pull request Nov 17, 2023
@SamuelTrahanNOAA
Fix several bugs in fv_regional_bc.F90 relating to uninitialized or i…
aa42f6e 
…ncorrectly initialized memory. (NOAA-EMC#219)

* fixes and workarounds for uninitialized memory in fv_regional_bc

* remove workarounds and fix remaining known bugs in ps_reg

* a few more surface pressure bug fixes; now the test case runs in debug mode

* workarounds and bug fixes from gnu compiler testing

* remove -9999999 commented-out code

* quiet the NaNs passed to Atmp%ps

* simplify comments and explain snan

* use i-1 & j-1 for two-point averages, when available

* Replace many changes with PR NOAA-EMC#220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

@junwang-noaa junwang-noaa junwang-noaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@climbfuji @junwang-noaa @DusanJovic-NOAA