Ww3 hycom

[heloisemichaud]

Pull Request Summary

adaptation to the hycom coupling

Description

Issue(s) addressed

Commit Message

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• If a version number update is required, checked the updating version number checklist.
• If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested?
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
• Have the matrix regression tests been run (if yes, please note HPC and compiler)?
• Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

[JessicaMeixner-NOAA]

Hi @heloisemichaud Thanks for this PR. This PR seems to be either build on or be a repeat of PR #888. Can you clarify? Also, we will need you to fill out the entire PR template.

[aronroland]

Hi All, I think this was the 1st try of Heloise and I will teach her a bit more please have a bit patience with us! Cheers Aron Von: Jessica Meixner ***@***.***> Gesendet: Donnerstag, 2. März 2023 13:53 An: NOAA-EMC/WW3 ***@***.***> Cc: Subscribed ***@***.***> Betreff: Re: [NOAA-EMC/WW3] Ww3 hycom (PR #926) Hi @heloisemichaud <https://github.com/heloisemichaud> Thanks for this PR. This PR seems to be either build on or be a repeat of PR #888 <#888> . Can you clarify? Also, we will need you to fill out the entire PR template. — Reply to this email directly, view it on GitHub <#926 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB2S43SRQ765LOQUZHU4RODW2CJZPANCNFSM6AAAAAAVNC2JAI> . You are receiving this because you are subscribed to this thread. <https://github.com/notifications/beacon/AB2S43UZMSWS5IC7A6TZNRDW2CJZPA5CNFSM6AAAAAAVNC2JAKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSWREDWK.gif> Message ID: ***@***.*** ***@***.***> >

[JessicaMeixner-NOAA]

@aronroland Happy to help! @heloisemichaud - just reply back with any questions you have - we're happy you've made a PR!

[aronroland]

just some clarification this will be a addition to the OASIS coupler, which is only dedicated when ww3 is coupled to hycom, whereas #888 is more general. Heloise and me will do some more training tomorrow and hopefully finish the pull request. Thanks for your understanding.

[MatthewMasarik-NOAA]

Hello @aronroland, I wanted to check in to see if there is anything needed from us for this PR? There is no rush of course if you continue to work on it, I just wanted to touch base on it.

[aronroland]

@MatthewMasarik-NOAA i will discuss with Heloise and provide some time line, this should be closed pretty soon. Thanks for pointing this out.

[MatthewMasarik-NOAA]

Thanks for the update, @aronroland. Please reach out if we can be of any help