Resolve compiler build 'remarks'

[MatthewMasarik-NOAA]

Describe the bug
When building WW3 there are a few compiler remarks that should be resolved.

To Reproduce
Compile WW3 then grep through the build log for remark.

Expected behavior
Compiling should not produce any error/warning/remark/etc messages.

Screenshots

[hfe07 WW3(fix-remarks/dev/ufs-weather-model)]$ grep 'remark' build.log 
/scratch1/NCEPDEV/climate/Matthew.Masarik/projs/UFS/support/WW3/model/src/w3arrymd.F90(2255): remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.
/scratch1/NCEPDEV/climate/Matthew.Masarik/projs/UFS/support/WW3/model/src/w3arrymd.F90(2256): remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.
/scratch1/NCEPDEV/climate/Matthew.Masarik/projs/UFS/support/WW3/model/src/w3arrymd.F90(2253): remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.
/scratch1/NCEPDEV/climate/Matthew.Masarik/projs/UFS/support/WW3/model/src/w3gridmd.F90(6360): remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.
/scratch1/NCEPDEV/climate/Matthew.Masarik/projs/UFS/support/WW3/model/src/w3tidemd.F90(826): remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.
/scratch1/NCEPDEV/climate/Matthew.Masarik/projs/UFS/support/WW3/model/src/w3tidemd.F90(830): remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.
/scratch1/NCEPDEV/climate/Matthew.Masarik/projs/UFS/support/WW3/model/src/w3wavemd.F90(414): remark #6536: All symbols from this module are already visible due to another USE; the ONLY clause will have no effect. Rename clauses, if any, will be honored.   [W3ODATMD]
/scratch1/NCEPDEV/climate/Matthew.Masarik/projs/UFS/support/WW3/model/src/ww3_outf.F90(2426): remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.
[hfe07 WW3(fix-remarks/dev/ufs-weather-model)]$ 

Additional context

• Addresses the WW3 component portion of this ufs-weather-model issue: Compiler warnings may not be suppressed ufs-community/ufs-weather-model#1984. For WW3 specific see discussion post: Compiler warnings may not be suppressed ufs-community/ufs-weather-model#1984 (comment).

[MatthewMasarik-NOAA]

Status

I've currently resolved all the remarks except the two in file, w3tidemd.F90, which involve the field width on a READ.

[JessicaMeixner-NOAA]

@MatthewMasarik-NOAA can we address these in the develop branch and then merge to dev/ufs-weather-model?

[MatthewMasarik-NOAA]

@mickaelaccensi, I was curious if you could comment on the following code. For the two READs below, would it be OK with you to adjust the field width for the E descriptors so they satisfy 'W>=D+7'?

WW3/model/src/w3tidemd.F90

Lines 824 to 832 in e085bcf

	!
	DO K=1,10
	READ(KR1,'(4X,A5,E16.10,i5)')TIDE_KONAN(K),TIDE_SIGAN(K),TIDE_NINF(k)
	! write(6,1010)TIDE_KONAN(K),TIDE_SIGAN(K),TIDE_NINF(k)
	IF (TIDE_KONAN(K).EQ.KBLANK) EXIT
	do k2=1,TIDE_NINF(k)
	read(kr1,'(4X,A5,E16.10,2F10.3)') TIDE_KONIN(K,k2),TIDE_SIGIN(K,k2),TIDE_R(K,k2),TIDE_ZETA(K,k2)
	END DO
	END DO

Satisfying the equality would take E16.10 to E17.10, and change the two READs to this:

READ(KR1,'(4X,A5,E17.10,i5)')TIDE_KONAN(K),TIDE_SIGAN(K),TIDE_NINF(k)

and

read(kr1,'(4X,A5,E17.10,2F10.3)') TIDE_KONIN(K,k2),TIDE_SIGIN(K,k2),TIDE_R(K,k2),TIDE_ZETA(K,k2)

[MatthewMasarik-NOAA]

@MatthewMasarik-NOAA can we address these in the develop branch and then merge to dev/ufs-weather-model?

@JessicaMeixner-NOAA, yes I think that should be straightforward. I'll confirm the compiler output for the develop branch and update the header accordingly.

[mickaelaccensi]

it should be fine. You can double check it works by running ww3_tp2.18.

Further in the code, it is even written in F12.9 format ....

            write(lp,79) TIDE_KONIN(k,k2),TIDE_SIGIN(k,k2),TIDE_ampci(k,k2,idef), &
                 TIDE_phgi(k,k2,idef)
79          format(5x,a5,4x,f12.9,15x,f10.4,5x,f10.4)

[MatthewMasarik-NOAA]

that's great to hear. thanks @mickaelaccensi for your quick reply. I'll do the check of ww3_tp2.18 -- thanks for that suggestion!

[MatthewMasarik-NOAA]

update

'dev/ufs-weather-model branch' has be taken out of the title and header. A PR with fixes for this issue will be submitted to the develop branch first, then synced from develop into dev/ufs-weather-model.

[MatthewMasarik-NOAA]

note

The USE statement that generate this remark in dev/ufs-weather-model

/scratch1/NCEPDEV/climate/Matthew.Masarik/projs/UFS/support/WW3/model/src/w3wavemd.F90(414): remark #6536: All symbols from this module are already visible due to another USE; the ONLY clause will have no effect. Rename clauses, if any, will be honored.   [W3ODATMD]

is not found in the develop branch, so will need to be added in when syncing into dev/ufs-weather-model.