Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created formal fortran namelist for itag. #402

Merged
merged 13 commits into from
Oct 27, 2021
Merged

Created formal fortran namelist for itag. #402

merged 13 commits into from
Oct 27, 2021

Conversation

kayeekayee
Copy link
Contributor

@kayeekayee kayeekayee commented Oct 4, 2021 •
edited
Loading

This code changes have been test on Cheyenne and Hera.
It is bitwise for both EMC and DTC regression test.

Latest code has been tested on 2 locations:
/scratch2/BMC/det/KaYee/UPP/UFFDA/itag/ (Hera)
/glade/scratch/kayee/UPP/itag/UFFDA (cheyenne)

These are the files being changed:
/scratch2/BMC/det/KaYee/UPP/UFFDA/itag/UPP_itag
modified: scripts/run_upp
modified: sorc/ncep_post.fd/WRFPOST.f
modified: ush/gfs_nceppost.sh

The EMC regression test scripts are also modified for this code on Hera:
/scratch2/BMC/det/KaYee/UPP/UFFDA/itag/EMC_RT_itag/jobs
run_post_fv3gfsv16_pe_test_HERA.sh
run_post_fv3gfsv16_HERA.sh
run_post_fv3gfs_pe_test_HERA.sh
run_post_fv3gfs_HERA.sh
run_post_rap_HERA.sh
run_post_rap_pe_test_HERA.sh
run_post_hrrr_HERA.sh
run_post_hrrr_pe_test_HERA.sh
run_post_nmmb_Grib2_HERA.sh
run_post_nmmb_Grib2_pe_test_HERA.sh
run_post_fv3r_HERA.sh
run_post_fv3r_pe_test_HERA.sh
run_post_fv3gefs_HERA.sh
run_post_fv3gefs_pe_test_HERA.sh
run_post_fv3hafs_HERA.sh
run_post_fv3hafs_pe_test_HERA.sh
run_post_3drtma_HERA.sh
run_post_3drtma_pe_test_HERA.sh

/scratch2/BMC/det/KaYee/UPP/UFFDA/itag/EMC_RT_itag/gfs/ush
gfs_nceppost.sh

@WenMeng-NOAA
Copy link
Collaborator

@kayeekayee Can you create a new issue regarding this PR?

@fossell
Copy link
Contributor

fossell commented Oct 5, 2021

@kayeekayee Can you create a new issue regarding this PR?

There is an existing issue already. I'll link it to this PR.

@fossell fossell linked an issue Oct 5, 2021 that may be closed by this pull request
Make itag fortran namelist #115
Closed
@HuiyaChuang-NOAA HuiyaChuang-NOAA mentioned this pull request Oct 7, 2021
Closed
@WenMeng-NOAA
Copy link
Collaborator

@kayeekayee and @fossell I did tests on WCOSS-Dell. The results look good. There will be coordination with model developers for this itag update. I would expect three more weeks for final merge.

WenMeng-NOAA
WenMeng-NOAA reviewed Oct 7, 2021
View reviewed changes
ush/global_nceppost.sh Outdated Show resolved Hide resolved
@WenMeng-NOAA
Copy link
Collaborator

@kayeekayee Could you sync your branch with upstream/develop? Thanks!

@WenMeng-NOAA WenMeng-NOAA added No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review. labels Oct 20, 2021
@fossell
Copy link
Contributor

fossell commented Oct 21, 2021

@kayeekayee - Can you please change this PR to active by clicking "ready for review"? It's currently still a Draft PR.

@kayeekayee kayeekayee marked this pull request as ready for review October 21, 2021 14:56
@kayeekayee kayeekayee requested a review from hertneky as a code owner October 21, 2021 14:56
WenMeng-NOAA
WenMeng-NOAA reviewed Oct 25, 2021
View reviewed changes
ush/gfs_nceppost.sh Outdated Show resolved Hide resolved
@WenMeng-NOAA
Copy link
Collaborator

The UPP regression tests were successfully passed on WCOSS-Dell, WCOSS-Cray and Hera. This PR is ready for merging.

@WenMeng-NOAA
Copy link
Collaborator

@fossell and @hertneky Do you have more comments on this PR?

@kayeekayee
Copy link
Contributor Author

The UPP regression tests were successfully passed on WCOSS-Dell, WCOSS-Cray and Hera. This PR is ready for merging.

Thank you so much for your confirmation, Wen.

fossell
fossell approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@fossell fossell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No additional comments from me.

hertneky
hertneky reviewed Oct 26, 2021
View reviewed changes
scripts/run_upp Outdated Show resolved Hide resolved
WenMeng-NOAA
WenMeng-NOAA reviewed Oct 27, 2021
View reviewed changes
ush/gfs_nceppost.sh Outdated Show resolved Hide resolved
hertneky
hertneky approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@hertneky hertneky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no other comments

@WenMeng-NOAA
Copy link
Collaborator

The tests on Hera were passed. This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit a774356 into NOAA-EMC:develop Oct 27, 2021
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Oct 27, 2021
Closed
@kayeekayee kayeekayee deleted the itag branch October 28, 2021 19:37
@hertneky hertneky mentioned this pull request Nov 18, 2021
Closed
@fossell fossell mentioned this pull request Feb 2, 2022
Closed
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
@chunhuazhou
Add RRFSE local config changes (NOAA-EMC#402)
c274665 
* Add RRFSE local config changes

* Add archiving of ensprod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenMeng-NOAA WenMeng-NOAA WenMeng-NOAA approved these changes

@hertneky hertneky hertneky approved these changes

@fossell fossell fossell approved these changes

Assignees
No one assigned
Labels
No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make itag fortran namelist
4 participants
@kayeekayee @WenMeng-NOAA @fossell @hertneky