Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMakeModules submodule #167

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Update CMakeModules submodule #167

merged 1 commit into from
Aug 19, 2020

Conversation

DusanJovic-NOAA
Copy link
Contributor

@DusanJovic-NOAA DusanJovic-NOAA commented Aug 19, 2020

This PR updates CMakeModules submodule after NOAA-EMC/CMakeModules#42

Copy link
Contributor

@fossell fossell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only changes CMake file. Need @WenMeng-NOAA's approval to merge though. @DusanJovic-NOAA - does this need to go into release/public-v1 as well?

@WenMeng-NOAA WenMeng-NOAA merged commit 4b531bc into NOAA-EMC:develop Aug 19, 2020
@DusanJovic-NOAA DusanJovic-NOAA deleted the update-cmakemodules branch August 19, 2020 16:27
@DusanJovic-NOAA
Copy link
Contributor Author

This PR only changes CMake file. Need @WenMeng-NOAA's approval to merge though. @DusanJovic-NOAA - does this need to go into release/public-v1 as well?

@fossell Please check with @climbfuji. The changes in CMakeModules are in FindNetCDF.cmake module to allow proper linking when netcdf is only available as static library.

EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants