Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone UPP failed to generate master file if compiling in debug mode #627

Closed
YaliMao-NOAA opened this issue Feb 8, 2023 · 9 comments · Fixed by #628
Closed

Standalone UPP failed to generate master file if compiling in debug mode #627

YaliMao-NOAA opened this issue Feb 8, 2023 · 9 comments · Fixed by #628

Comments

@YaliMao-NOAA
Copy link
Contributor

The standalone UPP running failed to generate master file if compiling UPP in debug mode, by modifying tests/compile_upp.sh:

  1. add line: debug_opt=" -DCMAKE_BUILD_TYPE=Debug"
  2. modify cmake_opts to: cmake_opts=" -DCMAKE_INSTALL_PREFIX=$prefix"${wrfio_opt}${gtg_opt}${ifi_opt}${debug_opt}
@WenMeng-NOAA
Copy link
Collaborator

@YaliMao-NOAA Would you like to submit a PR for this issue? Thanks!

@YaliMao-NOAA
Copy link
Contributor Author

I don't have a solution yet.

@WenMeng-NOAA
Copy link
Collaborator

@YaliMao-NOAA I mean adding a debug option in the build script compile_upp.sh.

@YaliMao-NOAA
Copy link
Contributor Author

I modified compile_upp.sh more to enable the option on the compiling command line. I made a PR.
As a heads up, wafs has no runtime error! But wafs grib2 files are not bit-wise consistent for different compiling options, debug and release.

@WenMeng-NOAA
Copy link
Collaborator

@YaliMao-NOAA

But wafs grib2 files are not bit-wise consistent for different compiling options, debug and release.
Did you compare values of each field? Any changed values?

@WenMeng-NOAA
Copy link
Collaborator

@YaliMao-NOAA This would be a separate PR from your delivery of wafs changes for GFS V17. After your branch "v17" is merged to the develop, do not recycle it for your wafs changes. You may open a new branch.

@WenMeng-NOAA
Copy link
Collaborator

@YaliMao-NOAA I would not expect bitwise identical results from different compiling options as long as field values are in reasonable range.

@YaliMao-NOAA
Copy link
Contributor Author

Did you compare values of each field? Any changed values?
I figured out the issue late yesterday and didn't have time to compare the values. Cactus is down today.

@YaliMao-NOAA
Copy link
Contributor Author

@YaliMao-NOAA This would be a separate PR from your delivery of wafs changes for GFS V17. After your branch "v17" is merged to the develop, do not recycle it for your wafs changes. You may open a new branch.

After you merge my branch 'v17' to your develop branch, can I delete my 'v17' branch, checkout your develop branch and create branch and recycle the name 'v17'?

@WenMeng-NOAA WenMeng-NOAA linked a pull request Feb 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants