Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code reads out-of-bounds at LM+1in three places #558

Closed
SamuelTrahanNOAA opened this issue Sep 1, 2022 · 0 comments · Fixed by #559
Closed

Code reads out-of-bounds at LM+1in three places #558

SamuelTrahanNOAA opened this issue Sep 1, 2022 · 0 comments · Fixed by #559
Assignees
@SamuelTrahanNOAA
Labels
bug Something isn't working

Comments

@SamuelTrahanNOAA
Copy link
Contributor

While testing another change, I found these out-of-bounds accesses:

  • Twice in MDL2SIGMA.f, the code can access element LM+1 if NL1XF(I,J)=LP1
  • UPP_PHYSICS.f: model can access out of array bounds when LCL(I,J) is at the model top

These happened in an RRFS case with extreme atmospheric conditions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamuelTrahanNOAA SamuelTrahanNOAA

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix out-of-bounds accesses and modernize some line-number do loops SamuelTrahanNOAA/UPP
2 participants
@SamuelTrahanNOAA @WenMeng-NOAA