Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HIRS from GSI regression tests #673

Closed
7 tasks done
ADCollard opened this issue Dec 21, 2023 · 0 comments · Fixed by #672
Closed
7 tasks done

Remove HIRS from GSI regression tests #673

ADCollard opened this issue Dec 21, 2023 · 0 comments · Fixed by #672

Comments

@ADCollard
Copy link
Contributor

Description

With the update to CRTM 2.4.0.1, an issue with versioning of CRTM HIRS files has been exposed. This is documented in JCSDA/spack-stack#922 and JCSDA/crtm#42.

As HIRS radiances are no longer used in the GSI, these data should be removed from the regression tests until a suitable update to CRTM is available.

Resolves #2182

Type of change

  • Bug fix (fixes something broken)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES - HIRS will no longer be processed, but results do not change as the data were passive.
  • Does this change require a documentation update? NO

How has this been tested?

Clone and build on Hera.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant