Sync w/ ESCOMP, add cpl_scalars for CSG and regional ATM domains #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable asyncio using pio ### Description of changes Allows IO tasks to be independent of compute tasks in cesm ### Specific notes (testing in progress) Contributors other than yourself, if any: Depends on share (ESCOMP/CESM_share#37) and cime (ESMCI/cime#4340). CMEPS Issues Fixed (include github issue #): Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial) Any User Interface Changes (namelist or namelist defaults changes)? ### Testing performed Testing performed if application target is CESM: - [ ] (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py - machines: - details (e.g. failed tests): - [ ] (recommended) CESM testlist_drv.xml - machines and compilers: - details (e.g. failed tests): - [X] (optional) CESM prealpha test - machines and compilers cheyenne intel - details (e.g. failed tests): results consistant with cesm2_3_alpha10d - [ ] (other) please described in detail - machines and compilers - details (e.g. failed tests): Testing performed if application target is UFS-coupled: - [ ] (recommended) UFS-coupled testing - description: - details (e.g. failed tests): Testing performed if application target is UFS-HAFS: - [X] (recommended) UFS-HAFS testing - description: - details (e.g. failed tests): ### Hashes used for testing: - [ ] CESM: - repository to check out: https://github.com/ESCOMP/CESM.git - branch/hash: - [ ] UFS-coupled, then umbrella repostiory to check out and associated hash: - repository to check out: - branch/hash: - [ ] UFS-HAFS, then umbrella repostiory to check out and associated hash: - repository to check out: - branch/hash:
fix the multi instance initialization
…port changes needed for CDEPS PR ESCOMP#213
new file: cesm/nuopc_cap_share/shr_lightning_coupling_mod.F90
modified: cime_config/namelist_definition_drv_flds.xml
modified: mediator/esmFldsExchange_cesm_mod.F90
modified: mediator/fd_cesm.yaml
modified: cesm/nuopc_cap_share/shr_lightning_coupling_mod.F90
modified: cime_config/namelist_definition_drv_flds.xml
modified: cime_config/namelist_definition_drv_flds.xml
modified: mediator/esmFldsExchange_cesm_mod.F90
modified: mediator/fd_cesm.yaml
make xgrid default, handle main task for multidriver cases in esm_tim…
xgrid was causing restart problems; revert this until we can solve those problems
Revert default aoflux_grid to ogrid
fieldNameList is not always allocated. We could wrap the deallocate in a conditional, but since allocatable arrays are automatically deallocated upon leaving a subroutine, this deallocate statement is unnecessary.
…ocate Remove unnecessary deallocate
…thub.com/jedwards4b/CMEPS/compare/ff8726f..79d6fa7 modified: cime_config/config_component.xml
Update nvhpc compiler for GPU settings Remove PGI compiler modified: cime_config/config_component.xml
so that they could assign multiple values to the config_machines.xml file modified: cime_config/config_component.xml
…14.18_lightning_coupling
There was already a comment claiming nitrogen deposition was being passed, so all I needed to add were the actual addfld_to(), addfld_from(), addmap_from(), and addmrg_to() calls.
replace aux_cam with aux_cmeps in testlist
Send nitrogen deposition from atm to ocn
add CAM linked lbs to exe build
modified: cesm/nuopc_cap_share/shr_lightning_coupling_mod.F90
CMEPS PR for CDEPS Inline implementation
* add new cpl_scalar for mediator history files for tiled gridded domains, eg cube-sphere. Replaces existing use of config variables which restricted the use to 6-tiles domain * remove unnecessary trims, fix minor typos and indentation
Add unstructured grid support for use with new Spectral Elements SCAM
* testing of this feature w/ UFS noahmp lnd component, which currently runs on the CSG, found two issues. One to write the mediator fractions and areas on the tiles when using the single history file. A second fix is the mapping masking for lnd-atm coupling in UFS.
Add index to cpl_scalars to allow CSG or regional (single tile) mediator history files for ATM component in UFS
DeniseWorthen
requested review from
uturuncoglu,
BrianCurtis-NOAA and
junwang-noaa
Merged
14 tasks
uturuncoglu
approved these changes
Mar 20, 2024
junwang-noaa
approved these changes
Mar 20, 2024
|
@DeniseWorthen testing is complete on WM PR #2175. Can you please merge this CMEPS PR for us? |
DeniseWorthen
added a commit
to DeniseWorthen/CMEPS
that referenced
this pull request
Jun 7, 2024
…A-EMC#115) * add cpl_scalar for tiled grids, other minor fixes * add new cpl_scalar for mediator history files for tiled gridded domains * remove unnecessary trims, fix minor typos and indentation * set ntile=0 when ntile scalar doesn't exist * modify dstmask for lnd->atm in UFS Co-authored-by: uturuncoglu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an index to cpl_scalars to allow 6 tiles of a CSG or a single tile of a regional ATM grid to be written as the required number of 2-d fields in the mediator history files. Replaces current implementation of this feature, which is limited to CSG and component level history files (ie, not history written by the history write phase).