Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLTYP incorrectly assigned to land use or vtype #102

Open
bbakernoaa opened this issue Nov 22, 2024 · 0 comments · May be fixed by #103 or NOAA-EMC/fv3atm#888
Open

SLTYP incorrectly assigned to land use or vtype #102

bbakernoaa opened this issue Nov 22, 2024 · 0 comments · May be fixed by #103 or NOAA-EMC/fv3atm#888
Labels
bug Something isn't working

Comments

@bbakernoaa
Copy link
Contributor

Description:

Current, the incorrect variable is being assigned to the surface type. Right now SLTYP is being passed from fv3 and being assigned to both the AQM sltyp variable as well as the LUFRAC_ variable. SLTYP is a categorical surface type but it doesn't define the vegetation cover but rather the USDA soil categories. The correct variable, vtype in GFSv16, needs to be passed from the ATM -> AQM. This can have large effects particularly on PM species as most of the domain would be classified as forests which have larger deposition velocities than say grasslands.

How To Reproduce:

  1. vtype is not in the advertise import list in aqm_cap.F90
  2. sltyp assigned to LUFRAC https://github.com/NOAA-EMC/AQM/blob/develop/src/shr/aqm_methods.F90#L663

Additional context:

Will need vtype added to the export state in fv3atm. A corresponding PR will need to be created there.

Once we move to GFSv16 we will also need to import the vegtype_frac from fv3atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant