Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RRDP metrics are blank after a 304 response. #580

Closed
partim opened this issue Jun 18, 2021 · 0 comments · Fixed by #613
Closed

RRDP metrics are blank after a 304 response. #580

partim opened this issue Jun 18, 2021 · 0 comments · Fixed by #613
Milestone
0.10.0

Comments

@partim
Copy link
Member

partim commented Jun 18, 2021

For the purpose of metrics, a 304 response by a server is treated as an error. It should instead be treated as a success with the previous metrics retained.
@partim partim added this to the 0.9.1 milestone Jun 18, 2021
@partim partim modified the milestones: 0.9.1, 0.10.0 Jul 7, 2021
@partim partim mentioned this issue Jul 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

Only include actually available data in RRDP status on 304. NLnetLabs/routinator
1 participant
@partim