Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate dense and free #40

Open
NicoRenaud opened this issue Feb 12, 2020 · 3 comments
Open

separate dense and free #40

NicoRenaud opened this issue Feb 12, 2020 · 3 comments

Comments

@NicoRenaud
Copy link
Collaborator

Should we separate the dense and free part of the code ? Having everything in one file makes it difficult to navigate (at least for me).

Also some subroutines have a dense and a free version while I think they should be the same (for example the DPR correction). We should simplify that.

@felipeZ
Copy link
Member

felipeZ commented Feb 12, 2020

I agree about separating the two implementations. Also, I have tried to make generic functions like DPR correction but I have not succeeded

@NicoRenaud
Copy link
Collaborator Author

I can look into the generic DPR. At the end of the day we only need the residues and the diagonal. So nothing of that require a free mat vec product

@felipeZ
Copy link
Member

felipeZ commented Feb 13, 2020

I Just realized that once we removed the ritz_vectors recalculation, the DPR free and dense subroutines are basically the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants