Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented DropDown and removed pycache files #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chauhannishh
Copy link
Contributor

Implemented DropDown in StudyZone

StudyZone Dropdown

All Submissions:

  • Have you followed the guidelines in our Contributing document?

New Feature Submissions:

  1. Does your submission pass build tests locally?
  2. Have you indented your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?

Implemented DropDown in StudyZone

StudyZone Dropdown
@monsij
Copy link
Member

monsij commented Dec 21, 2018

Hope that you have followed the contribution guidelines. Please don't make a request anywhere to get a review. One of the maintainers will get back to it within a day or so. 😃

(Powered by GitMate.io)

@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #92 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   93.97%   93.97%           
=======================================
  Files          19       19           
  Lines          83       83           
=======================================
  Hits           78       78           
  Misses          5        5
Impacted Files Coverage Δ
pro1/pro1/settings.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a25f38c...14ca447. Read the comment docs.

@monsij
Copy link
Member

monsij commented Dec 26, 2018

Many required files such as .github/ERROR_PAGES have been deleted. Hence it resulted in some conflicts as well. I'd suggest you to make changes from Github web interface itself and then make a PR. It is simpler and less complex that way @chauhannishh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants