Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMB-1137: Added tests to be run manually to check CIS2 refresh token expiry #290

Merged
merged 12 commits into from
Jun 21, 2022

Conversation

ChewieCB
Copy link
Contributor

Summary

  • 🤖 Updated existing CIS2 refresh token tests to check for increased expiry time, added new tests to test the refresh token is valid for up to 12 hours - these tests should be run manually due to the large amount of time taken to perform them.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

RyanThomas1214
RyanThomas1214 previously approved these changes Jun 16, 2022
ChewieCB added 2 commits June 17, 2022 16:18
…h scope when calling `/authorize`.

These test changes are dependent on this change to the `api_test_utils` library: NHSDigital/apim-test-utils#61
@ChewieCB
Copy link
Contributor Author

ChewieCB commented Jun 20, 2022

The new NHS Login tests are dependent on this change to the api_test_utils library and may not run green until the release is completed.
NHSDigital/apim-test-utils#61

@ChewieCB
Copy link
Contributor Author

ChewieCB commented Jun 21, 2022

Previous issues with builds failing during make install appear to have been caused by an issue with how poetry handes pip and setuptools in versions prior to 1.2.0a1:
python-poetry/poetry#3153
python-poetry/poetry#4242

This has been fixed as of this PR, that is included in version 1.2.0a1 onwards:
python-poetry/poetry#2826

The removal of references to setuptools within the poetry.lock file in 6143369 is a workaround to fix this issue in older versions of poetry without the above fix merged in.

Copy link
Contributor

@urchy urchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done Jack

@ChewieCB ChewieCB merged commit d92670d into master Jun 21, 2022
@ChewieCB ChewieCB deleted the amb-1137-cis2-12-hour-refresh branch June 21, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants