Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseos docker image build workflow #15

Open
2 tasks done
Tracked by #13
glemieux opened this issue Aug 31, 2024 · 3 comments · May be fixed by #18
Open
2 tasks done
Tracked by #13

baseos docker image build workflow #15

glemieux opened this issue Aug 31, 2024 · 3 comments · May be fixed by #18

Comments

@glemieux
Copy link
Collaborator

glemieux commented Aug 31, 2024

Tasks

Preview Give feedback
@glemieux
Copy link
Collaborator Author

glemieux commented Aug 31, 2024

Testing the baseos image by trying to generate a known working upstream (e.g. elm-fates) image build process would require building the elm-fates using the main branch of the repository.

For a pull request, it might be useful to load the image to a local registry instead of pushing to the official dockerhub registry. See here: https://docs.docker.com/build/ci/github-actions/local-registry/. As such, the build would only be pushed if it passed tests and was merged to main. This means that any changes to main should really be merged into the pull request branch during testing, which would need to be automated.

@glemieux glemieux linked a pull request Sep 2, 2024 that will close this issue
3 tasks
@glemieux
Copy link
Collaborator Author

glemieux commented Sep 2, 2024

Using the official docker platform emulation via github works and doesn't seem to struggle with #12 currently. The build does take a long time, which is not unexpected given emulation + building multiple packages from source, so it would be good to figure out how to leverage existing build layers to reduce future update build times.

  • Review if github build will pull from pre-existing image or if uploading artefact is necessary
  • Review cache options

@glemieux
Copy link
Collaborator Author

glemieux commented Sep 2, 2024

Moving testing tasks to a new issue to be addressed via a different pull request: #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant