Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamics history diagnostics could be split into more than 1 call #927

Open
rgknox opened this issue Oct 24, 2022 · 0 comments
Open

Dynamics history diagnostics could be split into more than 1 call #927

rgknox opened this issue Oct 24, 2022 · 0 comments

Comments

@rgknox
Copy link
Contributor

rgknox commented Oct 24, 2022

Paraphrasing from item 3 in #630:

The filling of history diagnostics for dynamics happens in 1 central location. This makes things complicated, particularly because the daily calls happen after all of our dynamics completes. If we want a diagnostic on growth or mortality rates (for example) , we have to then upscale the growth rates and save them to a site level intermediary variable, so that the information does not get messed-up during disturbance. Another example, if a cohort becomes terminated, we can't diagnose its rates because it ceases to exist. Long story short, if we were allowed to immediately update the history pointer arrays that are defined in FatesHistoryInterfaceMod when the salient variable is meaningfully updated, we would be able to remove all of these site-level intermediary arrays.

@rgknox rgknox changed the title Dynamics diagnostics could be split into more than 1 call Dynamics history diagnostics could be split into more than 1 call Oct 24, 2022
@Ngeetghub Ngeetghub moved this to ❕Todo in FATES issue board Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ❕Todo
Development

No branches or pull requests

1 participant