Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance improvement - split radiation into slow and fast routines #901

Open
rgknox opened this issue Sep 15, 2022 · 1 comment
Open

Comments

@rgknox
Copy link
Contributor

rgknox commented Sep 15, 2022

From an algorithmic perspective, radiation scattering in the canopy is governed by slow (plant canopy composition and structure) and fast (incident radiation intensity and zenith angle) processes.

subroutine PatchNormanRadiation is where we handle scattering. This routine performs calculations that rely on both fast and slow.

Speaking generally, I think there is a way to split this routine so that we can preprocess as much of the slow timescale stuff as possible, once a day, and therefore reduce the number of computations that happen at sub-hourly calls (zenith stuff). I'm not exactly sure how much things can be re-organized, but I think its worth a hard look.

@rosiealice
Copy link
Contributor

I agree @rgknox. In general it could obviously do with an overhaul and there's lots that could be pulled out here. Plus there is still, I think, an issue with radiation conservation in non SP modes, and that might help improve things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants