Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error in logic for calculating FATES_SEED_BANK history variable #900

Open
adamhb opened this issue Sep 13, 2022 · 2 comments
Open

error in logic for calculating FATES_SEED_BANK history variable #900

adamhb opened this issue Sep 13, 2022 · 2 comments
Labels
bug - science

Comments

@adamhb
Copy link
Contributor

adamhb commented Sep 13, 2022

Hi FATES team,
The seed bank gets multiplied by days_per_sec here, but this variable is a stock (not a flux). Removing this multiplication would fix the issue.
best,
Adam
@rgknox
Copy link
Contributor

rgknox commented Sep 14, 2022 •
edited
Loading

Thanks for posting this @adamhb
I agree with assessment and fix

@jenniferholm
Copy link
Contributor

Good find!

@glemieux glemieux moved this to ❕Todo in FATES issue board Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug - science
Projects
FATES issue board
Status: ❕Todo
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rgknox @glemieux @jenniferholm @adamhb