Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaf and root litter fines history variables are reversed. #808

Closed
JoshuaRady opened this issue Nov 11, 2021 · 3 comments
Closed

Leaf and root litter fines history variables are reversed. #808

JoshuaRady opened this issue Nov 11, 2021 · 3 comments

Comments

@JoshuaRady
Copy link

The following pointer references in FatesHistoryInterfaceMod.F90 are crossed causing the values of LITTER_FINES_AG_ELEM and LITTER_FINES_BG_ELEM history output variables to be reversed.

hio_fines_ag_elem => this%hvars(ih_fines_bg_elem)%r82d, &
hio_fines_bg_elem => this%hvars(ih_fines_ag_elem)%r82d, &

Obviously, this is a simple fix. I can put in a pull request, but will need to finish some work on my current branch before I can get to that.

@JoshuaRady
Copy link
Author

I thought this was timely with @adrifoster's output variable presentation going on today.

@adrifoster
Copy link
Contributor

@JoshuaRady thanks for catching this! I have just fixed this on my branch, and so this will be fixed with the ongoing PR.

@JoshuaRady
Copy link
Author

This issue has been resolved with the merger of Pull Request #802.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants